Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Issue 7978048: Don't ask the browser for Autofill suggestions for non-autofillable form fields. (Closed)

Created:
9 years, 3 months ago by Ilya Sherman
Modified:
9 years, 3 months ago
CC:
chromium-reviews, GeorgeY, brettw-cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., Ilya Sherman, dhollowa
Visibility:
Public.

Description

Don't ask the browser for Autofill suggestions for non-autofillable form fields. BUG=69914 TEST=browser_tests --gtest_filter=FormAutofillTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102240

Patch Set 1 #

Patch Set 2 : Update comment #

Patch Set 3 : Fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -128 lines) Patch
M chrome/browser/autofill/autofill_manager.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/autofill/autofill_manager.cc View 1 5 chunks +17 lines, -7 lines 0 comments Download
M chrome/renderer/autofill/autofill_agent.cc View 4 chunks +6 lines, -10 lines 0 comments Download
M chrome/renderer/autofill/autofill_browsertest.cc View 1 2 3 chunks +11 lines, -4 lines 0 comments Download
M chrome/renderer/autofill/form_autofill_browsertest.cc View 72 chunks +130 lines, -96 lines 0 comments Download
M chrome/renderer/autofill/form_autofill_util.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/renderer/autofill/form_autofill_util.cc View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ilya Sherman
Please send to the commit queue if all looks good.
9 years, 3 months ago (2011-09-22 00:36:55 UTC) #1
dhollowa
lgtm
9 years, 3 months ago (2011-09-22 01:06:15 UTC) #2
commit-bot: I haz the power
9 years, 3 months ago (2011-09-22 05:25:09 UTC) #3
Change committed as 102240

Powered by Google App Engine
This is Rietveld 408576698