Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6479)

Unified Diff: chrome/renderer/autofill/autofill_browsertest.cc

Issue 7978048: Don't ask the browser for Autofill suggestions for non-autofillable form fields. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix tests Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/autofill/autofill_agent.cc ('k') | chrome/renderer/autofill/form_autofill_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/autofill/autofill_browsertest.cc
diff --git a/chrome/renderer/autofill/autofill_browsertest.cc b/chrome/renderer/autofill/autofill_browsertest.cc
index 5b16fa0fa05b8160b78c93437fcb5ba9182afac1..ef1fe8725205d02891f39cbd9d18dbfed2951c5a 100644
--- a/chrome/renderer/autofill/autofill_browsertest.cc
+++ b/chrome/renderer/autofill/autofill_browsertest.cc
@@ -29,8 +29,9 @@ TEST_F(RenderViewTest, SendForms) {
LoadHTML("<form method=\"POST\">"
" <input type=\"text\" id=\"firstname\"/>"
- " <input type=\"text\" id=\"middlename\" autoComplete=\"off\"/>"
- " <input type=\"hidden\" id=\"lastname\"/>"
+ " <input type=\"text\" id=\"middlename\"/>"
+ " <input type=\"text\" id=\"lastname\" autoComplete=\"off\"/>"
+ " <input type=\"hidden\" id=\"email\"/>"
" <select id=\"state\"/>"
" <option>?</option>"
" <option>California</option>"
@@ -47,7 +48,7 @@ TEST_F(RenderViewTest, SendForms) {
AutofillHostMsg_FormsSeen::Read(message, &params);
const std::vector<FormData>& forms = params.a;
ASSERT_EQ(1UL, forms.size());
- ASSERT_EQ(3UL, forms[0].fields.size());
+ ASSERT_EQ(4UL, forms[0].fields.size());
FormField expected;
@@ -63,11 +64,17 @@ TEST_F(RenderViewTest, SendForms) {
expected.max_length = WebInputElement::defaultMaxLength();
EXPECT_FORM_FIELD_EQUALS(expected, forms[0].fields[1]);
+ expected.name = ASCIIToUTF16("lastname");
+ expected.value = string16();
+ expected.form_control_type = ASCIIToUTF16("text");
+ expected.max_length = WebInputElement::defaultMaxLength();
+ EXPECT_FORM_FIELD_EQUALS(expected, forms[0].fields[2]);
+
expected.name = ASCIIToUTF16("state");
expected.value = ASCIIToUTF16("?");
expected.form_control_type = ASCIIToUTF16("select-one");
expected.max_length = 0;
- EXPECT_FORM_FIELD_EQUALS(expected, forms[0].fields[2]);
+ EXPECT_FORM_FIELD_EQUALS(expected, forms[0].fields[3]);
// Verify that |didAcceptAutofillSuggestion()| sends the expected number of
// fields.
« no previous file with comments | « chrome/renderer/autofill/autofill_agent.cc ('k') | chrome/renderer/autofill/form_autofill_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698