Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 7974: Port a few test_shell_tests. Now it runs 45 of them.... (Closed)

Created:
12 years, 2 months ago by please use my chromium address
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Port a few test_shell_tests. Now it runs 45 of them. I removed some files from test_files because scons complains (warns) when a file is both in test_files and input_files. So the files removed from test_files also exist in input_files and at some pointed will be ported anyway. I also made some linking stubs. BUG=3674

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -94 lines) Patch
M base/base_lib.scons View 1 chunk +1 line, -0 lines 0 comments Download
A base/file_version_info_linux.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M net/base/x509_certificate_nss.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M webkit/glue/autocomplete_input_listener_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/glue/cpp_variant_unittest.cc View 5 chunks +7 lines, -8 lines 0 comments Download
M webkit/glue/glue_serialize_unittest.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M webkit/glue/multipart_response_delegate_unittest.cc View 5 chunks +4 lines, -5 lines 0 comments Download
M webkit/glue/password_autocomplete_listener_unittest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M webkit/port/platform/GKURL_unittest.cpp View 1 8 chunks +17 lines, -11 lines 0 comments Download
M webkit/tools/test_shell/SConscript View 1 3 chunks +12 lines, -24 lines 0 comments Download
M webkit/tools/test_shell/gtk/test_shell.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M webkit/tools/test_shell/image_decoder_unittest.h View 1 2 chunks +9 lines, -3 lines 0 comments Download
M webkit/tools/test_shell/image_decoder_unittest.cc View 1 3 chunks +14 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
please use my chromium address
12 years, 2 months ago (2008-10-24 17:06:05 UTC) #1
Mark Mentovai
Nice job http://codereview.chromium.org/7974/diff/1/5 File webkit/port/platform/GKURL_unittest.cpp (right): http://codereview.chromium.org/7974/diff/1/5#newcode38 Line 38: #pragma warning(push, 0) Use the compiler_specific.h ...
12 years, 2 months ago (2008-10-24 17:12:55 UTC) #2
please use my chromium address
After some recent updates more of the files link, so after few stubs more (and ...
12 years, 2 months ago (2008-10-25 14:26:43 UTC) #3
Evan Martin
looking now
12 years, 1 month ago (2008-10-27 19:54:10 UTC) #4
Evan Martin
12 years, 1 month ago (2008-10-27 22:48:42 UTC) #5
r4031
(I reordered some of your #includes to alphabetical)

Powered by Google App Engine
This is Rietveld 408576698