Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Unified Diff: webkit/glue/cpp_variant_unittest.cc

Issue 7974: Port a few test_shell_tests. Now it runs 45 of them.... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 12 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/glue/autocomplete_input_listener_unittest.cc ('k') | webkit/glue/glue_serialize_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/cpp_variant_unittest.cc
===================================================================
--- webkit/glue/cpp_variant_unittest.cc (revision 3977)
+++ webkit/glue/cpp_variant_unittest.cc (working copy)
@@ -53,7 +53,7 @@
void CheckObject(const NPVariant& actual) {
EXPECT_EQ(NPVariantType_Object, actual.type);
EXPECT_TRUE(actual.value.objectValue);
- EXPECT_EQ(1, actual.value.objectValue->referenceCount);
+ EXPECT_EQ(1U, actual.value.objectValue->referenceCount);
EXPECT_EQ(1, g_allocate_call_count);
EXPECT_EQ(0, g_deallocate_call_count);
}
@@ -117,10 +117,10 @@
NPObject *object = MakeVoidObject();
source.Set(object);
// 2 references so far.
- EXPECT_EQ(2, source.value.objectValue->referenceCount);
+ EXPECT_EQ(2U, source.value.objectValue->referenceCount);
CppVariant dest = source;
- EXPECT_EQ(3, dest.value.objectValue->referenceCount);
+ EXPECT_EQ(3U, dest.value.objectValue->referenceCount);
EXPECT_EQ(1, g_allocate_call_count);
NPN_ReleaseObject(object);
source.SetNull();
@@ -147,11 +147,11 @@
NPObject *object = MakeVoidObject();
source.Set(object);
// 2 references so far.
- EXPECT_EQ(2, source.value.objectValue->referenceCount);
+ EXPECT_EQ(2U, source.value.objectValue->referenceCount);
CppVariant dest;
dest = source;
- EXPECT_EQ(3, dest.value.objectValue->referenceCount);
+ EXPECT_EQ(3U, dest.value.objectValue->referenceCount);
EXPECT_EQ(1, g_allocate_call_count);
NPN_ReleaseObject(object);
@@ -300,7 +300,6 @@
CheckString("std test string", cpp);
// NPString
- const char *ascii_str = "test NPString";
NPString np_ascii_str = { "test NPString",
static_cast<uint32_t>(strlen("test NPString")) };
cpp.Set(np_ascii_str);
@@ -336,9 +335,9 @@
CppVariant cpp;
NPObject* object = MakeVoidObject();
cpp.Set(object);
- EXPECT_EQ(2, object->referenceCount);
+ EXPECT_EQ(2U, object->referenceCount);
cpp.FreeData();
- EXPECT_EQ(1, object->referenceCount);
+ EXPECT_EQ(1U, object->referenceCount);
EXPECT_EQ(0, g_deallocate_call_count);
cpp.Set(object);
« no previous file with comments | « webkit/glue/autocomplete_input_listener_unittest.cc ('k') | webkit/glue/glue_serialize_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698