Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: webkit/glue/password_autocomplete_listener_unittest.cc

Issue 7974: Port a few test_shell_tests. Now it runs 45 of them.... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 12 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/glue/multipart_response_delegate_unittest.cc ('k') | webkit/port/platform/GKURL_unittest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/password_autocomplete_listener_unittest.cc
===================================================================
--- webkit/glue/password_autocomplete_listener_unittest.cc (revision 3977)
+++ webkit/glue/password_autocomplete_listener_unittest.cc (working copy)
@@ -35,12 +35,12 @@
class TestHTMLInputDelegate : public HTMLInputDelegate {
public:
- TestHTMLInputDelegate() : did_call_on_finish_(false),
+ TestHTMLInputDelegate() : HTMLInputDelegate(NULL),
+ did_call_on_finish_(false),
did_set_value_(false),
did_set_selection_(false),
selection_start_(0),
- selection_end_(0),
- HTMLInputDelegate(NULL) {
+ selection_end_(0) {
}
// Override those methods we implicitly invoke in the tests.
@@ -163,7 +163,7 @@
EXPECT_EQ(username1_, username_delegate->GetValue());
EXPECT_EQ(password1_, password_delegate->GetValue());
// And the selection should have been set to 'lice', the last 4 letters.
- EXPECT_EQ(1, username_delegate->selection_start());
+ EXPECT_EQ(1U, username_delegate->selection_start());
EXPECT_EQ(username1_.length(), username_delegate->selection_end());
// And both fields should have observed OnFinishedAutocompleting.
EXPECT_TRUE(username_delegate->did_call_on_finish());
@@ -175,7 +175,7 @@
// different start value.
EXPECT_EQ(username1_, username_delegate->GetValue());
EXPECT_EQ(password1_, password_delegate->GetValue());
- EXPECT_EQ(2, username_delegate->selection_start());
+ EXPECT_EQ(2U, username_delegate->selection_start());
EXPECT_EQ(username1_.length(), username_delegate->selection_end());
// Now lets say the user goes astray from the stored username and types
@@ -202,7 +202,7 @@
// The username and password fields should match the 'bob' entry.
EXPECT_EQ(username2_, username_delegate->GetValue());
EXPECT_EQ(password2_, password_delegate->GetValue());
- EXPECT_EQ(1, username_delegate->selection_start());
+ EXPECT_EQ(1U, username_delegate->selection_start());
EXPECT_EQ(username2_.length(), username_delegate->selection_end());
// The End.
« no previous file with comments | « webkit/glue/multipart_response_delegate_unittest.cc ('k') | webkit/port/platform/GKURL_unittest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698