Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5072)

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 7972018: Don't depend on the embedder creating a plugin. That way embedders can always provide an empty Co... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/chrome_content_renderer_client.h ('k') | content/renderer/content_renderer_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/chrome_content_renderer_client.cc
===================================================================
--- chrome/renderer/chrome_content_renderer_client.cc (revision 102285)
+++ chrome/renderer/chrome_content_renderer_client.cc (working copy)
@@ -265,23 +265,20 @@
return l10n_util::GetStringUTF8(IDS_DEFAULT_ENCODING);
}
-WebPlugin* ChromeContentRendererClient::CreatePlugin(
+bool ChromeContentRendererClient::OverrideCreatePlugin(
RenderView* render_view,
WebFrame* frame,
- const WebPluginParams& original_params) {
+ const WebPluginParams& params,
+ WebKit::WebPlugin** plugin) {
bool is_default_plugin;
- WebPlugin* plugin = CreatePluginImpl(render_view,
- frame,
- original_params,
- &is_default_plugin);
- if (!plugin || is_default_plugin)
+ *plugin = CreatePlugin(render_view, frame, params, &is_default_plugin);
+ if (!*plugin || is_default_plugin)
MissingPluginReporter::GetInstance()->ReportPluginMissing(
- original_params.mimeType.utf8(),
- original_params.url);
- return plugin;
+ params.mimeType.utf8(), params.url);
+ return true;
}
-WebPlugin* ChromeContentRendererClient::CreatePluginImpl(
+WebPlugin* ChromeContentRendererClient::CreatePlugin(
RenderView* render_view,
WebFrame* frame,
const WebPluginParams& original_params,
« no previous file with comments | « chrome/renderer/chrome_content_renderer_client.h ('k') | content/renderer/content_renderer_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698