Issue 7969013: Fix pc to code cache so it can cope with a pointer to the start of the code

Issue 7969013: Fix pc to code cache so it can cope with a pointer to the start of the code (Closed)

Created:
9 years, 3 months ago by Erik Corry

Modified:
9 years, 3 months ago

Reviewers:
Rico

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix pc to code cache so it can cope with a pointer to the start of the code object. Rename it to be the inner pointer to code cache. Committed: http://code.google.com/p/v8/source/detail?r=9336

Patch Set 3 : '' #

Total comments: 10

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -49 lines)			Patch
M	src/frames.h	View	1 2	1 chunk	+9 lines, -9 lines	8 comments	Download
M	src/frames.cc	View	1 2	5 chunks	+32 lines, -25 lines	0 comments	Download
M	src/frames-inl.h	View	1 2	1 chunk	+1 line, -1 line	2 comments	Download
M	src/heap.cc	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/incremental-marking.cc	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/isolate.h	View	1 2	3 chunks	+5 lines, -3 lines	0 comments	Download
M	src/isolate.cc	View	1 2	3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/mark-compact.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects-inl.h	View	1 2	1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Rico

LGTM http://codereview.chromium.org/7969013/diff/5/src/frames.cc File src/frames.cc (right): http://codereview.chromium.org/7969013/diff/5/src/frames.cc#newcode1173 src/frames.cc:1173: Code* PcToCodeCache::GcSafeFindCodeForPc(Address pc) { We should consider renaming ...

9 years, 3 months ago (2011-09-20 09:10:35 UTC) #2

Rico

LGTM http://codereview.chromium.org/7969013/diff/3003/src/frames-inl.h File src/frames-inl.h (right): http://codereview.chromium.org/7969013/diff/3003/src/frames-inl.h#newcode108 src/frames-inl.h:108: inline Code* StackFrame::GetContainingCode(Isolate* isolate, Address pc) { Argument ...

9 years, 3 months ago (2011-09-20 09:38:45 UTC) #4

Erik Corry

9 years, 3 months ago (2011-09-20 09:44:11 UTC) #5

http://codereview.chromium.org/7969013/diff/3003/src/frames-inl.h
File src/frames-inl.h (right):

http://codereview.chromium.org/7969013/diff/3003/src/frames-inl.h#newcode108
src/frames-inl.h:108: inline Code* StackFrame::GetContainingCode(Isolate*
isolate, Address pc) {
On 2011/09/20 09:38:45, Rico wrote:
> Argument variable name should probably something like address instead of pc

No, here in the frame code it is actually always a PC.

http://codereview.chromium.org/7969013/diff/3003/src/frames.h
File src/frames.h (right):

http://codereview.chromium.org/7969013/diff/3003/src/frames.h#newcode64
src/frames.h:64: Code* GcSafeFindCodeForInnerPointer(Address pc);
On 2011/09/20 09:38:45, Rico wrote:
> address instead of pc?

Done.

http://codereview.chromium.org/7969013/diff/3003/src/frames.h#newcode65
src/frames.h:65: Code* GcSafeCastToCode(HeapObject* object, Address pc);
On 2011/09/20 09:38:45, Rico wrote:
> same as above

Done.

http://codereview.chromium.org/7969013/diff/3003/src/frames.h#newcode71
src/frames.h:71: InnerPointerToCodeCacheEntry* GetCacheEntry(Address pc);
On 2011/09/20 09:38:45, Rico wrote:
> same as above

Done.

http://codereview.chromium.org/7969013/diff/3003/src/frames.h#newcode79
src/frames.h:79: InnerPointerToCodeCacheEntry cache_[kPcToCodeCacheSize];
On 2011/09/20 09:38:45, Rico wrote:
> kAddressToCodeCacheSize?

kInnerPointerToCodeCacheSize

Expand Messages | Collapse Messages