Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Side by Side Diff: src/frames-inl.h

Issue 7969013: Fix pc to code cache so it can cope with a pointer to the start of the code (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« src/frames.h ('K') | « src/frames.cc ('k') | src/heap.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 inline StackFrame::StackFrame(StackFrameIterator* iterator) 98 inline StackFrame::StackFrame(StackFrameIterator* iterator)
99 : iterator_(iterator), isolate_(iterator_->isolate()) { 99 : iterator_(iterator), isolate_(iterator_->isolate()) {
100 } 100 }
101 101
102 102
103 inline StackHandler* StackFrame::top_handler() const { 103 inline StackHandler* StackFrame::top_handler() const {
104 return iterator_->handler(); 104 return iterator_->handler();
105 } 105 }
106 106
107 107
108 inline Code* StackFrame::GetContainingCode(Isolate* isolate, Address pc) { 108 inline Code* StackFrame::GetContainingCode(Isolate* isolate, Address pc) {
Rico 2011/09/20 09:38:45 Argument variable name should probably something l
Erik Corry 2011/09/20 09:44:11 No, here in the frame code it is actually always a
109 return isolate->pc_to_code_cache()->GetCacheEntry(pc)->code; 109 return isolate->inner_pointer_to_code_cache()->GetCacheEntry(pc)->code;
110 } 110 }
111 111
112 112
113 inline Object* StandardFrame::GetExpression(int index) const { 113 inline Object* StandardFrame::GetExpression(int index) const {
114 return Memory::Object_at(GetExpressionAddress(index)); 114 return Memory::Object_at(GetExpressionAddress(index));
115 } 115 }
116 116
117 117
118 inline void StandardFrame::SetExpression(int index, Object* value) { 118 inline void StandardFrame::SetExpression(int index, Object* value) {
119 Memory::Object_at(GetExpressionAddress(index)) = value; 119 Memory::Object_at(GetExpressionAddress(index)) = value;
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
245 template<typename Iterator> 245 template<typename Iterator>
246 void JavaScriptFrameIteratorTemp<Iterator>::Reset() { 246 void JavaScriptFrameIteratorTemp<Iterator>::Reset() {
247 iterator_.Reset(); 247 iterator_.Reset();
248 if (!done()) Advance(); 248 if (!done()) Advance();
249 } 249 }
250 250
251 251
252 } } // namespace v8::internal 252 } } // namespace v8::internal
253 253
254 #endif // V8_FRAMES_INL_H_ 254 #endif // V8_FRAMES_INL_H_
OLDNEW
« src/frames.h ('K') | « src/frames.cc ('k') | src/heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698