Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Unified Diff: src/frames.h

Issue 7969013: Fix pc to code cache so it can cope with a pointer to the start of the code (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/frames.cc » ('j') | src/frames-inl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/frames.h
===================================================================
--- src/frames.h (revision 9328)
+++ src/frames.h (working copy)
@@ -49,36 +49,36 @@
class ThreadLocalTop;
class Isolate;
-class PcToCodeCache {
+class InnerPointerToCodeCache {
public:
- struct PcToCodeCacheEntry {
- Address pc;
+ struct InnerPointerToCodeCacheEntry {
+ Address inner_pointer;
Code* code;
SafepointEntry safepoint_entry;
};
- explicit PcToCodeCache(Isolate* isolate) : isolate_(isolate) {
+ explicit InnerPointerToCodeCache(Isolate* isolate) : isolate_(isolate) {
Flush();
}
- Code* GcSafeFindCodeForPc(Address pc);
+ Code* GcSafeFindCodeForInnerPointer(Address pc);
Rico 2011/09/20 09:38:45 address instead of pc?
Erik Corry 2011/09/20 09:44:11 Done.
Code* GcSafeCastToCode(HeapObject* object, Address pc);
Rico 2011/09/20 09:38:45 same as above
Erik Corry 2011/09/20 09:44:11 Done.
void Flush() {
memset(&cache_[0], 0, sizeof(cache_));
}
- PcToCodeCacheEntry* GetCacheEntry(Address pc);
+ InnerPointerToCodeCacheEntry* GetCacheEntry(Address pc);
Rico 2011/09/20 09:38:45 same as above
Erik Corry 2011/09/20 09:44:11 Done.
private:
- PcToCodeCacheEntry* cache(int index) { return &cache_[index]; }
+ InnerPointerToCodeCacheEntry* cache(int index) { return &cache_[index]; }
Isolate* isolate_;
static const int kPcToCodeCacheSize = 1024;
- PcToCodeCacheEntry cache_[kPcToCodeCacheSize];
+ InnerPointerToCodeCacheEntry cache_[kPcToCodeCacheSize];
Rico 2011/09/20 09:38:45 kAddressToCodeCacheSize?
Erik Corry 2011/09/20 09:44:11 kInnerPointerToCodeCacheSize
- DISALLOW_COPY_AND_ASSIGN(PcToCodeCache);
+ DISALLOW_COPY_AND_ASSIGN(InnerPointerToCodeCache);
};
« no previous file with comments | « no previous file | src/frames.cc » ('j') | src/frames-inl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698