Add support for running NaCl-Chrome integration tests on Win64

Add support for running NaCl-Chrome integration tests on Win64
BUG=28176
TEST=this change

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41348

[Ian Ni-Lewis (Google), 2010-03-10 18:23:13]

http://codereview.chromium.org/791002/diff/1/2
File chrome/test/nacl/nacl_test.cc (right):

http://codereview.chromium.org/791002/diff/1/2#newcode77
chrome/test/nacl/nacl_test.cc:77: bool use_x64_nexes = false;
I'd prefer us to use NaClOsIs64BitWindows() from nacl_os_qualify, rather than
re-implementing that functionality here.

Your implementation is different from the implementation in nacl_os_qualify--if
you have reason to believe yours is better, feel free to update the os_qualify
function.

[gregoryd, 2010-03-10 23:04:55]

http://codereview.chromium.org/791002/diff/1/2
File chrome/test/nacl/nacl_test.cc (right):

http://codereview.chromium.org/791002/diff/1/2#newcode77
chrome/test/nacl/nacl_test.cc:77: bool use_x64_nexes = false;
On 2010/03/10 18:23:13, Ian Lewis (Google) wrote:
> I'd prefer us to use NaClOsIs64BitWindows() from nacl_os_qualify, rather than
> re-implementing that functionality here.
> 
> Your implementation is different from the implementation in
nacl_os_qualify--if
> you have reason to believe yours is better, feel free to update the os_qualify
> function.

Done.

[sehr (please use chromium), 2010-03-11 21:23:00]

One request.  Otherwise, LGTM.

http://codereview.chromium.org/791002/diff/8001/9003
File DEPS (right):

http://codereview.chromium.org/791002/diff/8001/9003#newcode9
DEPS:9: "nacl_revision": "1696",
We may want this to incorporate a later revision (after my CL), if that's not
too much trouble.

[gregoryd, 2010-03-11 21:43:14]

Ok, let me know when it's in

On Thu, Mar 11, 2010 at 13:23, <sehr@google.com> wrote:

> One request.  Otherwise, LGTM.
>
>
> http://codereview.chromium.org/791002/diff/8001/9003
> File DEPS (right):
>
> http://codereview.chromium.org/791002/diff/8001/9003#newcode9
> DEPS:9: "nacl_revision": "1696",
> We may want this to incorporate a later revision (after my CL), if
> that's not too much trouble.
>
>
> http://codereview.chromium.org/791002
>