Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4246)

Unified Diff: chrome/test/nacl/nacl_test.cc

Issue 791002: Add support for running NaCl-Chrome integration tests on Win64 (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_tests.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/nacl/nacl_test.cc
===================================================================
--- chrome/test/nacl/nacl_test.cc (revision 41324)
+++ chrome/test/nacl/nacl_test.cc (working copy)
@@ -8,6 +8,7 @@
#include "chrome/common/chrome_paths.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/test/automation/tab_proxy.h"
+#include "native_client/src/trusted/platform_qualify/nacl_os_qualify.h"
#include "net/base/escape.h"
#include "net/base/net_util.h"
@@ -59,6 +60,11 @@
#if defined(OS_MACOSX)
launch_arguments_.AppendSwitch(switches::kNoSandbox);
#endif
+
+#if defined(OS_WIN)
+ if (NaClOsIs64BitWindows())
+ launch_arguments_.AppendSwitch(switches::kNoSandbox);
+#endif
}
NaClTest::~NaClTest() {}
@@ -74,7 +80,16 @@
FilePath NaClTest::GetTestBinariesDir() {
FilePath path = GetTestRootDir();
path = path.AppendASCII("prebuilt");
- path = path.AppendASCII("x86");
+ bool use_x64_nexes = false;
+#if defined(OS_WIN)
+ if (NaClOsIs64BitWindows())
+ use_x64_nexes = true;
+#endif
+
+ if (use_x64_nexes)
+ path = path.AppendASCII("x64");
+ else
+ path = path.AppendASCII("x86");
return path;
}
@@ -241,6 +256,7 @@
}
#if defined(OS_MACOSX)
+// http://code.google.com/p/nativeclient/issues/detail?id=342
TEST_F(NaClTest, FLAKY_ServerTest) {
#else
TEST_F(NaClTest, ServerTest) {
@@ -250,6 +266,7 @@
}
#if defined(OS_MACOSX)
+// http://code.google.com/p/nativeclient/issues/detail?id=342
TEST_F(NaClTest, FLAKY_SrpcHelloWorld) {
#else
TEST_F(NaClTest, SrpcHelloWorld) {
@@ -259,6 +276,7 @@
}
#if defined(OS_MACOSX)
+// http://code.google.com/p/nativeclient/issues/detail?id=342
TEST_F(NaClTest, FLAKY_SrpcBasicTest) {
#else
TEST_F(NaClTest, SrpcBasicTest) {
@@ -268,6 +286,7 @@
}
#if defined(OS_MACOSX)
+// http://code.google.com/p/nativeclient/issues/detail?id=342
TEST_F(NaClTest, FLAKY_SrpcSockAddrTest) {
#else
TEST_F(NaClTest, SrpcSockAddrTest) {
@@ -277,6 +296,7 @@
}
#if defined(OS_MACOSX)
+// http://code.google.com/p/nativeclient/issues/detail?id=342
TEST_F(NaClTest, FLAKY_SrpcShmTest) {
#else
TEST_F(NaClTest, SrpcShmTest) {
@@ -286,6 +306,7 @@
}
#if defined(OS_MACOSX)
+// http://code.google.com/p/nativeclient/issues/detail?id=342
TEST_F(NaClTest, FLAKY_SrpcPluginTest) {
#else
TEST_F(NaClTest, SrpcPluginTest) {
@@ -295,6 +316,7 @@
}
#if defined(OS_MACOSX)
+// http://code.google.com/p/nativeclient/issues/detail?id=342
TEST_F(NaClTest, FLAKY_SrpcNrdXferTest) {
#else
TEST_F(NaClTest, SrpcNrdXferTest) {
« no previous file with comments | « chrome/chrome_tests.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698