Fixes saving files that don't have valid extensions.

Fixes saving files that don't have valid extensions.

Two fixes here. First was a disturbing discovery that FilePath::Extension returns an extension starting with a period. I am of the belief that this is the wrong API to expose, but that's a different fight. Fixed.

Second is a subtle behavior of the old code that wasn't preserved. In the case where the extension did not exist in the registry, the old code dropped the extension from the filter. We now also do so.

BUG=10561
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13960

[scherkus (not reviewing), 2009-04-17 19:36:41]

LGTM however I'm not familiar with this code :(

http://codereview.chromium.org/79045/diff/1008/1010
File chrome/browser/download/save_package.cc (right):

http://codereview.chromium.org/79045/diff/1008/1010#newcode1
Line 1: // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
bump copyright year

http://codereview.chromium.org/79045/diff/1008/1010#newcode1025
Line 1025: file_type_info.extensions[0][0].erase(0, 1);  // drop the .
I'm not familiar with this code but it looks duplicated

maybe we can refactor it down the road

http://codereview.chromium.org/79045/diff/1008/1011
File chrome/common/win_util.cc (right):

http://codereview.chromium.org/79045/diff/1008/1011#newcode1
Line 1: // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
bump copyright year

http://codereview.chromium.org/79045/diff/1008/1012
File chrome/common/win_util.h (right):

http://codereview.chromium.org/79045/diff/1008/1012#newcode1
Line 1: // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
bump copyright year

[Avi (use Gerrit), 2009-04-17 19:43:53]

http://codereview.chromium.org/79045/diff/1008/1010
File chrome/browser/download/save_package.cc (right):

http://codereview.chromium.org/79045/diff/1008/1010#newcode1025
Line 1025: file_type_info.extensions[0][0].erase(0, 1);  // drop the .
On 2009/04/17 19:36:41, scherkus wrote:
> I'm not familiar with this code but it looks duplicated
> 
> maybe we can refactor it down the road

I want FilePath.Extension() to not provide leading dots. On Monday I return to
the NY office where I can make my case in person.

[scherkus (not reviewing), 2009-04-17 19:45:07]

just another comment

http://codereview.chromium.org/79045/diff/1008/1009
File chrome/browser/download/download_manager.cc (right):

http://codereview.chromium.org/79045/diff/1008/1009#newcode645
Line 645: file_type_info.extensions[0][0].erase(0, 1);  // drop the .
wait.. would it make sense to DCHECK this?

".txt" --> "txt" today, but what if:
"txt" --> "xt" in the future?

again, not familiar with the code :)

[sky, 2009-04-20 16:21:54]

LGTM.

[Evan Stade, 2009-04-20 19:35:24]

this is not the first time that the FilePath::Extension() function has bitten
someone. On the other hand, file_util::GetFileExtensionFromPath() returns the
extension with no period. Intuitive, right?