chrome/browser/download/download_manager.cc - Issue 79045: Fixes saving files that don't have valid extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_manager.cc

Issue 79045: Fixes saving files that don't have valid extensions. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 11 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/download_manager.cc

===================================================================

--- chrome/browser/download/download_manager.cc (revision 13948)

+++ chrome/browser/download/download_manager.cc (working copy)

@@ -641,6 +641,8 @@

SelectFileDialog::FileTypeInfo file_type_info;

file_type_info.extensions.resize(1);

file_type_info.extensions[0].push_back(info->suggested_path.Extension());

+ if (!file_type_info.extensions[0][0].empty())

+ file_type_info.extensions[0][0].erase(0, 1); // drop the .

scherkus (not reviewing) 2009/04/17 19:45:07 wait.. would it make sense to DCHECK this? ".txt"

file_type_info.include_all_files = true;

gfx::NativeWindow owning_window =

contents ? platform_util::GetTopLevel(contents->GetNativeView()) : NULL;