Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6123)

Unified Diff: chrome/browser/download/save_package.cc

Issue 79045: Fixes saving files that don't have valid extensions. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/save_package.cc
===================================================================
--- chrome/browser/download/save_package.cc (revision 13948)
+++ chrome/browser/download/save_package.cc (working copy)
@@ -1021,6 +1021,8 @@
} else {
file_type_info.extensions.resize(1);
file_type_info.extensions[0].push_back(suggested_path.Extension());
+ if (!file_type_info.extensions[0][0].empty())
+ file_type_info.extensions[0][0].erase(0, 1); // drop the .
scherkus (not reviewing) 2009/04/17 19:36:41 I'm not familiar with this code but it looks dupli
Avi (use Gerrit) 2009/04/17 19:43:53 I want FilePath.Extension() to not provide leading
file_type_info.include_all_files = true;
file_type_index = 1;
}

Powered by Google App Engine
This is Rietveld 408576698