Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: chrome/browser/autofill/phone_number.h

Issue 7892048: Autofill: Remove fax number completely. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autofill/phone_number.h
diff --git a/chrome/browser/autofill/phone_number.h b/chrome/browser/autofill/phone_number.h
index 652cb709f8b348a1ac01117f59139b0c257ee04b..1eda750e3c559edb0e6d92831f487567f272e7f8 100644
--- a/chrome/browser/autofill/phone_number.h
+++ b/chrome/browser/autofill/phone_number.h
@@ -49,14 +49,14 @@ class PhoneNumber : public FormGroup {
static const size_t kSuffixLength = 4;
// The following functions should return the field type for each part of the
- // phone number. Currently, these are either fax or home phone number types.
+ // phone number.
AutofillFieldType GetNumberType() const;
AutofillFieldType GetCityCodeType() const;
AutofillFieldType GetCountryCodeType() const;
AutofillFieldType GetCityAndNumberType() const;
AutofillFieldType GetWholeNumberType() const;
Ilya Sherman 2011/09/15 03:47:08 Let's just get rid of these, as well as the whole
James Hawkins 2011/09/16 03:23:28 Done.
- // The class used to combine home phone or fax parts into a whole number.
+ // The class used to combine home phone parts into a whole number.
class PhoneCombineHelper {
public:
explicit PhoneCombineHelper(AutofillType::FieldTypeGroup phone_group);
@@ -96,7 +96,7 @@ class PhoneNumber : public FormGroup {
// since the last time the cache was updated.
void UpdateCacheIfNeeded() const;
- // Phone group - currently it is PHONE_HOME and PHONE_FAX.
+ // Phone group - currently it is PHONE_HOME.
AutofillType::FieldTypeGroup phone_group_;
Ilya Sherman 2011/09/15 03:47:08 There's no reason to store the |phone_group_| here
James Hawkins 2011/09/16 03:23:28 Done.
// The phone number.
string16 number_;

Powered by Google App Engine
This is Rietveld 408576698