Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Unified Diff: chrome/browser/autofill/phone_field_unittest.cc

Issue 7892048: Autofill: Remove fax number completely. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autofill/phone_field_unittest.cc
diff --git a/chrome/browser/autofill/phone_field_unittest.cc b/chrome/browser/autofill/phone_field_unittest.cc
index 983556784e30ce8da994c41fcb80c96eb78ed1f6..4f8dbd1d2d75a9db11da45703f81606bddf18f2b 100644
--- a/chrome/browser/autofill/phone_field_unittest.cc
+++ b/chrome/browser/autofill/phone_field_unittest.cc
@@ -197,79 +197,6 @@ TEST_F(PhoneFieldTest, ThreePartPhoneNumberPrefixSuffix2) {
EXPECT_EQ(PHONE_HOME_NUMBER, field_type_map_[ASCIIToUTF16("phone3")]);
}
-TEST_F(PhoneFieldTest, ParseOneLineFax) {
- webkit_glue::FormField field;
- field.form_control_type = ASCIIToUTF16("text");
-
- field.label = ASCIIToUTF16("Fax");
- field.name = ASCIIToUTF16("fax");
- list_.push_back(new AutofillField(field, ASCIIToUTF16("fax1")));
-
- AutofillScanner scanner(list_.get());
- field_.reset(Parse(&scanner));
- ASSERT_NE(static_cast<PhoneField*>(NULL), field_.get());
- ASSERT_TRUE(field_->ClassifyField(&field_type_map_));
- ASSERT_TRUE(
- field_type_map_.find(ASCIIToUTF16("fax1")) != field_type_map_.end());
- EXPECT_EQ(PHONE_FAX_WHOLE_NUMBER, field_type_map_[ASCIIToUTF16("fax1")]);
-}
-
-TEST_F(PhoneFieldTest, ParseTwoLineFax) {
- webkit_glue::FormField field;
- field.form_control_type = ASCIIToUTF16("text");
-
- field.label = ASCIIToUTF16("Area Code");
- field.name = ASCIIToUTF16("area code");
- list_.push_back(new AutofillField(field, ASCIIToUTF16("areacode1")));
-
- field.label = ASCIIToUTF16("Fax");
- field.name = ASCIIToUTF16("fax");
- list_.push_back(new AutofillField(field, ASCIIToUTF16("fax2")));
-
- AutofillScanner scanner(list_.get());
- field_.reset(Parse(&scanner));
- ASSERT_NE(static_cast<PhoneField*>(NULL), field_.get());
- ASSERT_TRUE(field_->ClassifyField(&field_type_map_));
- ASSERT_TRUE(
- field_type_map_.find(ASCIIToUTF16("areacode1")) != field_type_map_.end());
- // It should be FAX, based on the other phone in the group.
- EXPECT_EQ(PHONE_FAX_CITY_CODE, field_type_map_[ASCIIToUTF16("areacode1")]);
- ASSERT_TRUE(
- field_type_map_.find(ASCIIToUTF16("fax2")) != field_type_map_.end());
- EXPECT_EQ(PHONE_FAX_NUMBER, field_type_map_[ASCIIToUTF16("fax2")]);
-}
-
-TEST_F(PhoneFieldTest, ThreePartFaxNumberPrefixSuffix) {
- webkit_glue::FormField field;
- field.form_control_type = ASCIIToUTF16("text");
-
- field.label = ASCIIToUTF16("Fax:");
- field.name = ASCIIToUTF16("area");
- list_.push_back(new AutofillField(field, ASCIIToUTF16("areacode1")));
-
- field.label = string16();
- field.name = ASCIIToUTF16("prefix");
- list_.push_back(new AutofillField(field, ASCIIToUTF16("prefix2")));
-
- field.label = string16();
- field.name = ASCIIToUTF16("suffix");
- list_.push_back(new AutofillField(field, ASCIIToUTF16("suffix3")));
-
- AutofillScanner scanner(list_.get());
- field_.reset(Parse(&scanner));
- ASSERT_NE(static_cast<PhoneField*>(NULL), field_.get());
- ASSERT_TRUE(field_->ClassifyField(&field_type_map_));
- ASSERT_TRUE(
- field_type_map_.find(ASCIIToUTF16("areacode1")) != field_type_map_.end());
- EXPECT_EQ(PHONE_FAX_CITY_CODE, field_type_map_[ASCIIToUTF16("areacode1")]);
- ASSERT_TRUE(
- field_type_map_.find(ASCIIToUTF16("prefix2")) != field_type_map_.end());
- EXPECT_EQ(PHONE_FAX_NUMBER, field_type_map_[ASCIIToUTF16("prefix2")]);
- ASSERT_TRUE(
- field_type_map_.find(ASCIIToUTF16("suffix3")) != field_type_map_.end());
- EXPECT_EQ(PHONE_FAX_NUMBER, field_type_map_[ASCIIToUTF16("suffix3")]);
-}
-
TEST_F(PhoneFieldTest, CountryAndCityAndPhoneNumber) {
// Phone in format <country code>:3 - <city and number>:10
// The |maxlength| is considered, otherwise it's too broad.

Powered by Google App Engine
This is Rietveld 408576698