Autofill: Remove fax number completely.

chrome/browser/autofill/phone_number.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_AUTOFILL_PHONE_NUMBER_H_
 #define CHROME_BROWSER_AUTOFILL_PHONE_NUMBER_H_
 #pragma once
 
 #include <string>
 #include <vector>
@@ skipping 31 matching lines @@
   virtual bool SetCanonicalizedInfo(AutofillFieldType type,
                                     const string16& value) OVERRIDE;
 
   // Size and offset of the prefix and suffix portions of phone numbers.
   static const size_t kPrefixOffset = 0;
   static const size_t kPrefixLength = 3;
   static const size_t kSuffixOffset = 3;
   static const size_t kSuffixLength = 4;
 
   // The following functions should return the field type for each part of the
-  // phone number.  Currently, these are either fax or home phone number types.
+  // phone number.
   AutofillFieldType GetNumberType() const;
   AutofillFieldType GetCityCodeType() const;
   AutofillFieldType GetCountryCodeType() const;
   AutofillFieldType GetCityAndNumberType() const;
   AutofillFieldType GetWholeNumberType() const;

[Ilya Sherman, 2011/09/15 03:47:08]

Let's just get rid of these, as well as the whole HomePhoneNumber class.

[James Hawkins, 2011/09/16 03:23:28]

Done.

 
-  // The class used to combine home phone or fax parts into a whole number.
+  // The class used to combine home phone parts into a whole number.
   class PhoneCombineHelper {
    public:
     explicit PhoneCombineHelper(AutofillType::FieldTypeGroup phone_group);
     ~PhoneCombineHelper();
 
     // If |type| is a phone field type, saves the |value| accordingly and
     // returns true.  For all other field types returs false.
     bool SetInfo(AutofillFieldType type, const string16& value);
 
     // Returns true if parsing was successful, false otherwise.
     bool ParseNumber(const std::string& locale, string16* value);
 
     // Returns true if both |phone_| and |whole_number_| are empty.
     bool IsEmpty() const;
 
    private:
     string16 country_;
     string16 city_;
     string16 phone_;
     string16 whole_number_;
     AutofillType::FieldTypeGroup phone_group_;

[Ilya Sherman, 2011/09/15 03:47:08]

There's no reason to store the |phone_group_| here any more.

[James Hawkins, 2011/09/16 03:23:28]

Done.

   };
 
  private:
   FRIEND_TEST_ALL_PREFIXES(PhoneNumberTest, Matcher);
 
   // FormGroup:
   virtual void GetSupportedTypes(FieldTypeSet* supported_types) const OVERRIDE;
 
   // Validates |number_| and translates it into digits-only format.
   bool NormalizePhone();
 
   // Returns the locale for this phone number, based on the |profile_|.
   std::string locale() const;
 
   // Updates the cached parsed number if the profile's locale has changed
   // since the last time the cache was updated.
   void UpdateCacheIfNeeded() const;
 
-  // Phone group -  currently it is PHONE_HOME and PHONE_FAX.
+  // Phone group -  currently it is PHONE_HOME.
   AutofillType::FieldTypeGroup phone_group_;

[Ilya Sherman, 2011/09/15 03:47:08]

There's no reason to store the |phone_group_| here any more.

[James Hawkins, 2011/09/16 03:23:28]

Done.

   // The phone number.
   string16 number_;
   // Profile which stores the locale used as hint when normalizing the number.
   AutofillProfile* profile_;  // WEAK
 
   // Cached number.
   mutable autofill_i18n::PhoneObject cached_parsed_phone_;
 };
 
 #endif  // CHROME_BROWSER_AUTOFILL_PHONE_NUMBER_H_