Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7886042: Move Aura to UI subdir. (Closed)

Created:
9 years, 3 months ago by Ben Goodger (Google)
Modified:
9 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, dhollowa, Paweł Hajdan Jr.
Visibility:
Public.

Description

Move Aura to UI subdir. BUG=none TEST=none TBR=sky Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101156

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -2513 lines) Patch
D aura/DEPS View 1 chunk +0 lines, -6 lines 0 comments Download
D aura/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D aura/aura.gyp View 1 chunk +0 lines, -98 lines 0 comments Download
D aura/aura_export.h View 1 chunk +0 lines, -30 lines 0 comments Download
D aura/demo/demo_main.cc View 1 chunk +0 lines, -109 lines 0 comments Download
D aura/desktop.h View 1 chunk +0 lines, -80 lines 0 comments Download
D aura/desktop.cc View 1 chunk +0 lines, -88 lines 0 comments Download
D aura/desktop_host.h View 1 chunk +0 lines, -47 lines 0 comments Download
D aura/desktop_host_linux.cc View 1 chunk +0 lines, -122 lines 0 comments Download
D aura/desktop_host_win.h View 1 chunk +0 lines, -60 lines 0 comments Download
D aura/desktop_host_win.cc View 1 chunk +0 lines, -96 lines 0 comments Download
D aura/event.h View 1 chunk +0 lines, -111 lines 0 comments Download
D aura/event.cc View 1 chunk +0 lines, -66 lines 0 comments Download
D aura/event_win.cc View 1 chunk +0 lines, -222 lines 0 comments Download
D aura/event_x.cc View 1 chunk +0 lines, -193 lines 0 comments Download
D aura/focus_manager.h View 1 chunk +0 lines, -37 lines 0 comments Download
D aura/focus_manager.cc View 1 chunk +0 lines, -32 lines 0 comments Download
D aura/hit_test.h View 1 chunk +0 lines, -42 lines 0 comments Download
D aura/root_window.h View 1 chunk +0 lines, -43 lines 0 comments Download
D aura/root_window.cc View 1 chunk +0 lines, -58 lines 0 comments Download
D aura/run_all_unittests.cc View 1 chunk +0 lines, -9 lines 0 comments Download
D aura/test_suite.h View 1 chunk +0 lines, -22 lines 0 comments Download
D aura/test_suite.cc View 1 chunk +0 lines, -32 lines 0 comments Download
D aura/window.h View 1 chunk +0 lines, -166 lines 0 comments Download
D aura/window.cc View 1 chunk +0 lines, -175 lines 0 comments Download
D aura/window_delegate.h View 1 chunk +0 lines, -53 lines 0 comments Download
D aura/window_manager.h View 1 chunk +0 lines, -47 lines 0 comments Download
D aura/window_manager.cc View 1 chunk +0 lines, -66 lines 0 comments Download
D aura/window_unittest.cc View 1 chunk +0 lines, -281 lines 0 comments Download
M build/all.gyp View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/platform_util_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/aura/aura_init.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +1 line, -1 line 0 comments Download
M + ui/aura/aura.gyp View 2 chunks +16 lines, -16 lines 1 comment Download
M + ui/aura/aura_export.h View 2 chunks +3 lines, -3 lines 0 comments Download
M + ui/aura/demo/demo_main.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M + ui/aura/desktop.h View 2 chunks +5 lines, -5 lines 0 comments Download
M + ui/aura/desktop.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M + ui/aura/desktop_host.h View 2 chunks +3 lines, -3 lines 0 comments Download
M + ui/aura/desktop_host_linux.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M + ui/aura/desktop_host_win.h View 2 chunks +4 lines, -4 lines 0 comments Download
M + ui/aura/desktop_host_win.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M + ui/aura/event.h View 2 chunks +4 lines, -4 lines 0 comments Download
M + ui/aura/event.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M + ui/aura/event_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M + ui/aura/event_x.cc View 1 chunk +1 line, -1 line 0 comments Download
M + ui/aura/focus_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
M + ui/aura/focus_manager.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M + ui/aura/hit_test.h View 2 chunks +3 lines, -3 lines 0 comments Download
M + ui/aura/root_window.h View 2 chunks +4 lines, -4 lines 0 comments Download
M + ui/aura/root_window.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M + ui/aura/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M + ui/aura/test_suite.h View 2 chunks +3 lines, -3 lines 0 comments Download
M + ui/aura/test_suite.cc View 1 chunk +1 line, -1 line 0 comments Download
M + ui/aura/window.h View 2 chunks +4 lines, -4 lines 0 comments Download
M + ui/aura/window.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M + ui/aura/window_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
M + ui/aura/window_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
M + ui/aura/window_manager.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M + ui/aura/window_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M ui/gfx/native_widget_types.h View 1 chunk +3 lines, -1 line 0 comments Download
M views/aura_desktop/aura_desktop_main.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M views/events/event_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/views.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M views/widget/native_widget_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M views/widget/native_widget_aura.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ben Goodger (Google)
9 years, 3 months ago (2011-09-14 20:57:08 UTC) #1
sky
9 years, 3 months ago (2011-09-14 21:04:45 UTC) #2 
lgtm

http://codereview.chromium.org/7886042/diff/1/ui/aura/aura.gyp
File ui/aura/aura.gyp (right):

http://codereview.chromium.org/7886042/diff/1/ui/aura/aura.gyp#newcode52
ui/aura/aura.gyp:52: '<(DEPTH)/base/base.gyp:base',
Mark says avoid DEPTH like the plague.

Powered by Google App Engine
This is Rietveld 408576698