Access Session::config() and Session::jid() on the correct thread only.

Access Session::config() and Session::jid() on the correct thread only.

BUG=88600
TEST=Unittests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100866

[Wez, 2011-09-10 01:10:02]

LGTM.

http://codereview.chromium.org/7867019/diff/2001/remoting/host/chromoting_hos...
File remoting/host/chromoting_host.cc (right):

http://codereview.chromium.org/7867019/diff/2001/remoting/host/chromoting_hos...
remoting/host/chromoting_host.cc:455: connection->session()->jid()));
It seems kinda broken that we have to pull these out to pass to
HandleLocalLoginSucceeded, given that it has access to the ConnectionToClient.
:(

http://codereview.chromium.org/7867019/diff/2001/remoting/host/chromoting_host.h
File remoting/host/chromoting_host.h (right):

http://codereview.chromium.org/7867019/diff/2001/remoting/host/chromoting_hos...
remoting/host/chromoting_host.h:131: const std::string& jid);
Should this be OnLocalLoginSucceded(), or AddAuthenticatedClient() or something
of that sort?

[Sergey Ulanov, 2011-09-10 07:02:04]

http://codereview.chromium.org/7867019/diff/2001/remoting/host/chromoting_host.h
File remoting/host/chromoting_host.h (right):

http://codereview.chromium.org/7867019/diff/2001/remoting/host/chromoting_hos...
remoting/host/chromoting_host.h:131: const std::string& jid);
On 2011/09/10 01:10:03, Wez wrote:
> Should this be OnLocalLoginSucceded(), or AddAuthenticatedClient() or
something
> of that sort?
Renamed to AddAuthenticatedClient

[Sergey Ulanov, 2011-09-12 22:13:38]

Wez, please take a look at this CL again. I've fixed the crash that Lambros
found, and cleaned up other places where jid() was called on a wrong thread.

[Wez, 2011-09-12 22:40:44]

http://codereview.chromium.org/7867019/diff/5001/remoting/host/chromoting_hos...
File remoting/host/chromoting_host.cc (right):

http://codereview.chromium.org/7867019/diff/5001/remoting/host/chromoting_hos...
remoting/host/chromoting_host.cc:303: connection->Init(session);
Why did this move?

http://codereview.chromium.org/7867019/diff/5001/remoting/host/chromoting_hos...
remoting/host/chromoting_host.cc:390: // Disable the "curtain" if there are no
more active clients.
Update this comment.

http://codereview.chromium.org/7867019/diff/5001/remoting/host/chromoting_hos...
remoting/host/chromoting_host.cc:394: // If that client has disconnected, then
we can kill the recorder.
Simpler to say "If there are no authenticated clients, we can stop the
recorder."

http://codereview.chromium.org/7867019/diff/5001/remoting/host/plugin/host_sc...
File remoting/host/plugin/host_script_object.cc (right):

http://codereview.chromium.org/7867019/diff/5001/remoting/host/plugin/host_sc...
remoting/host/plugin/host_script_object.cc:337: client_username_.replace(pos,
std::string::npos, "");
Not related to this CL per-se, but should we be decoding the JID to get the user
name some other way?

[Sergey Ulanov, 2011-09-12 22:53:21]

http://codereview.chromium.org/7867019/diff/5001/remoting/host/chromoting_hos...
File remoting/host/chromoting_host.cc (right):

http://codereview.chromium.org/7867019/diff/5001/remoting/host/chromoting_hos...
remoting/host/chromoting_host.cc:303: connection->Init(session);
On 2011/09/12 22:40:44, Wez wrote:
> Why did this move?
Because ClientSession constructor now needs to access connection->session(). And
it just makes more sense to initialize object after it's created.

http://codereview.chromium.org/7867019/diff/5001/remoting/host/chromoting_hos...
remoting/host/chromoting_host.cc:390: // Disable the "curtain" if there are no
more active clients.
On 2011/09/12 22:40:44, Wez wrote:
> Update this comment.

Done.

http://codereview.chromium.org/7867019/diff/5001/remoting/host/chromoting_hos...
remoting/host/chromoting_host.cc:394: // If that client has disconnected, then
we can kill the recorder.
On 2011/09/12 22:40:44, Wez wrote:
> Simpler to say "If there are no authenticated clients, we can stop the
> recorder."

Done.

http://codereview.chromium.org/7867019/diff/5001/remoting/host/plugin/host_sc...
File remoting/host/plugin/host_script_object.cc (right):

http://codereview.chromium.org/7867019/diff/5001/remoting/host/plugin/host_sc...
remoting/host/plugin/host_script_object.cc:337: client_username_.replace(pos,
std::string::npos, "");
On 2011/09/12 22:40:44, Wez wrote:
> Not related to this CL per-se, but should we be decoding the JID to get the
user
> name some other way?
We could use buzz::Jid class here, but it means that this code would have to
depend on libjingle, and I would rather avoid it given that the current code
works just fine.

[Wez, 2011-09-12 23:20:11]

LGTM

[commit-bot: I haz the power, 2011-09-13 05:21:12]

Change committed as 100866