Access Session::config() and Session::jid() on the correct thread only.

remoting/host/plugin/host_script_object.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/plugin/host_script_object.h"
 
 #include "base/bind.h"
 #include "base/message_loop.h"
 #include "base/message_loop_proxy.h"
 #include "base/sys_string_conversions.h"
@@ skipping 305 matching lines @@
 }
 
 void HostNPScriptObject::OnAccessDenied() {
   DCHECK(host_context_.network_message_loop()->BelongsToCurrentThread());
 
   ++failed_login_attempts_;
   if (failed_login_attempts_ == kMaxLoginAttempts)
     DisconnectInternal();
 }
 
-void HostNPScriptObject::OnClientAuthenticated(
-    remoting::protocol::ConnectionToClient* client) {
+void HostNPScriptObject::OnClientAuthenticated(const std::string& jid) {
   DCHECK_EQ(MessageLoop::current(), host_context_.main_message_loop());
 
   if (state_ == kDisconnecting) {
     // Ignore the new connection if we are disconnecting.
     return;
   }
 
-  client_username_ = client->session()->jid();
+  client_username_ = jid;
   size_t pos = client_username_.find('/');
   if (pos != std::string::npos)
     client_username_.replace(pos, std::string::npos, "");

[Wez, 2011/09/12 22:40:44]

Not related to this CL per-se, but should we be decoding the JID to get the user
name some other way?

[Sergey Ulanov, 2011/09/12 22:53:22]

We could use buzz::Jid class here, but it means that this code would have to
depend on libjingle, and I would rather avoid it given that the current code
works just fine.

   LOG(INFO) << "Client " << client_username_ << " connected.";
   SetState(kConnected);
 }
 
-void HostNPScriptObject::OnClientDisconnected(
-    remoting::protocol::ConnectionToClient* client) {
+void HostNPScriptObject::OnClientDisconnected(const std::string& jid) {
   DCHECK_EQ(MessageLoop::current(), host_context_.main_message_loop());
 
   client_username_.clear();
 
   // Disconnect the host when a client disconnects.
   DisconnectInternal();
 }
 
 void HostNPScriptObject::OnShutdown() {
   DCHECK_EQ(MessageLoop::current(), host_context_.main_message_loop());
@@ skipping 417 matching lines @@
                                                uint32_t argCount) {
   NPVariant np_result;
   bool is_good = g_npnetscape_funcs->invokeDefault(plugin_, func, args,
                                                    argCount, &np_result);
   if (is_good)
       g_npnetscape_funcs->releasevariantvalue(&np_result);
   return is_good;
 }
 
 }  // namespace remoting