Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Unified Diff: remoting/protocol/jingle_session.cc

Issue 7867019: Access Session::config() and Session::jid() on the correct thread only. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix tests Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/host/register_support_host_request.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/jingle_session.cc
diff --git a/remoting/protocol/jingle_session.cc b/remoting/protocol/jingle_session.cc
index b80239c62ccb0796d9e69495b400079b69093d0c..b30101c1244ee932064c33d4eb53c6925630da6f 100644
--- a/remoting/protocol/jingle_session.cc
+++ b/remoting/protocol/jingle_session.cc
@@ -165,10 +165,7 @@ net::Socket* JingleSession::event_channel() {
}
const std::string& JingleSession::jid() {
- // TODO(sergeyu): Fix ChromotingHost so that it doesn't call this
- // method on invalid thread and uncomment this DCHECK.
- // See crbug.com/88600 .
- // DCHECK(CalledOnValidThread());
+ DCHECK(CalledOnValidThread());
return jid_;
}
@@ -192,10 +189,7 @@ const std::string& JingleSession::local_certificate() const {
}
const SessionConfig& JingleSession::config() {
- // TODO(sergeyu): Fix ChromotingHost so that it doesn't call this
- // method on invalid thread and uncomment this DCHECK.
- // See crbug.com/88600 .
- // DCHECK(CalledOnValidThread());
+ DCHECK(CalledOnValidThread());
DCHECK(config_set_);
return config_;
}
« no previous file with comments | « remoting/host/register_support_host_request.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698