Update subprocess2.check_output() to behave like subprocess.check_output().

Update subprocess2.check_output() to behave like subprocess.check_output().

stderr is not redirected by default. stdout is not allowed.
Both were oversight.
Do not override stdin=None in case the user would response to stderr output for
example.

Increase test coverage.

R=dpranke@chromium.org
BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100456

[M-A Ruel, 2011-09-09 15:02:34]

This is needed to fix git_cl.py conversion. Making behavior consistent with
python2.7 is also a goal.

[M-A Ruel, 2011-09-09 15:25:13]

update the callers since their expected behavior differed from python 2.7
check_output() behavior anyway.

[Dirk Pranke, 2011-09-09 18:10:38]

LGTM w/ nits.

http://codereview.chromium.org/7860041/diff/2001/subprocess2.py
File subprocess2.py (right):

http://codereview.chromium.org/7860041/diff/2001/subprocess2.py#newcode253
subprocess2.py:253: None.
Grammar nit: "Automatically converts stdout=PIPE or stderr=PIPE to VOID since
the output isn't returned either way. No exception is thrown when stdout is not
None."

Although I'm not sure why you need to document the second sentence?

http://codereview.chromium.org/7860041/diff/2001/subprocess2.py#newcode290
subprocess2.py:290: # Similar to check_output, deny using stdout arg.
Grammar nit: "Like check_output(), we ignore any stdout arg that was passed in."

[M-A Ruel, 2011-09-09 18:59:20]

http://codereview.chromium.org/7860041/diff/2001/subprocess2.py
File subprocess2.py (right):

http://codereview.chromium.org/7860041/diff/2001/subprocess2.py#newcode253
subprocess2.py:253: None.
Looks like the docstring was unclear since it's not what it meant. Clarified it.

http://codereview.chromium.org/7860041/diff/2001/subprocess2.py#newcode290
subprocess2.py:290: # Similar to check_output, deny using stdout arg.
On 2011/09/09 18:10:38, Dirk Pranke wrote:
> Grammar nit: "Like check_output(), we ignore any stdout arg that was passed
in."

No it's denied. Clarified comment.

[commit-bot: I haz the power, 2011-09-09 19:01:31]

Change committed as 100456