gclient_scm.py - Issue 7860041: Update subprocess2.check_output() to behave like subprocess.check_output().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gclient_scm.py

Issue 7860041: Update subprocess2.check_output() to behave like subprocess.check_output(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: update comment and docstring, they were unclear Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gclient_scm.py

diff --git a/gclient_scm.py b/gclient_scm.py

index 15e9eb9b2a57aeedeefb7fc3a81e105ac2906a73..4500dffc8d99712d7e042284d2171956ccb09060 100644

--- a/gclient_scm.py

+++ b/gclient_scm.py

@@ -665,7 +665,9 @@ class GitWrapper(SCMWrapper):

def _Capture(self, args):

return subprocess2.check_output(

- ['git'] + args, cwd=self.checkout_path).strip()

+ ['git'] + args,

+ stderr=subprocess2.PIPE,

+ cwd=self.checkout_path).strip()

def _Run(self, args, options, **kwargs):

kwargs.setdefault('cwd', self.checkout_path)

« no previous file with comments | « checkout.py ('k') | presubmit_canned_checks.py » ('j') | no next file with comments »