PRESUBMIT.py - Issue 7860041: Update subprocess2.check_output() to behave like subprocess.check_output().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 7860041: Update subprocess2.check_output() to behave like subprocess.check_output(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: update comment and docstring, they were unclear Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index 127cc906c8f4461cc5c78d060339a4671907978e..ebe5061de5025c9118820658c16e8b1ee1429070 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -85,7 +85,8 @@ def RunGitClTests(input_api, output_api):

[input_api.os_path.join(test_path, test)], cwd=test_path)

else:

input_api.subprocess.check_output(

- [input_api.os_path.join(test_path, test)], cwd=test_path)

+ [input_api.os_path.join(test_path, test)], cwd=test_path,

+ stderr=input_api.subprocess.STDOUT)

except (OSError, input_api.subprocess.CalledProcessError), e:

results.append(output_api.PresubmitError('%s failed\n%s' % (test, e)))

except local_rietveld.Failure, e:

« no previous file with comments | « no previous file | checkout.py » ('j') | no next file with comments »