Issue 7838008: Revert 99648 - Reland 98392 - Split WebGraphicsContext3DCommandBufferImpl::initialize() into two ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7838008: Revert 99648 - Reland 98392 - Split WebGraphicsContext3DCommandBufferImpl::initialize() into two ... (Closed)

Created:
9 years, 3 months ago by jamesr

Modified:
9 years, 3 months ago

Reviewers:
lain Merrick

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 99648 - Reland 98392 - Split WebGraphicsContext3DCommandBufferImpl::initialize() into two stages. After the context is created, the remaining calls should be done on the compositor thread. This CL adds a MaybeInitializeGL() method, which we run on each call to makeContextCurrent(). Added asserts to RendererGLContext to check that it's always used on the same thread. Original review URL: http://codereview.chromium.org/7713015 Reverted due to buildbot errors: http://codereview.chromium.org/7745042 Review URL: http://codereview.chromium.org/7828046 TBR=husky@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99825

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -103 lines)			Patch
M	content/renderer/gpu/renderer_gl_context.cc	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.h	View	4 chunks	+0 lines, -17 lines	0 comments	Download
M	content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.cc	View	7 chunks	+58 lines, -83 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lain Merrick

9 years, 3 months ago (2011-09-07 10:18:55 UTC) #2

LGTM

Just initializing in isContextLost would work around this, I guess. Or returning
false if we're not initialized yet.

If we try this approach yet again, how can we prevent similar problems in
future? Would we need to MaybeInitializeGL in *all* the WebGraphicsContext3D
entrypoints?

Expand Messages | Collapse Messages