Issue 7745042: Revert 98392 - Split WebGraphicsContext3DCommandBufferImpl::initialize() into two stages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7745042: Revert 98392 - Split WebGraphicsContext3DCommandBufferImpl::initialize() into two stages. (Closed)

Created:
9 years, 4 months ago by Wez

Modified:
9 years, 4 months ago

Reviewers:
lain Merrick

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 98392 - Split WebGraphicsContext3DCommandBufferImpl::initialize() into two stages. After the context is created, the remaining calls should be done on the compositor thread. This CL adds a MaybeInitializeGL() method, which we run on each call to makeContextCurrent(). Added asserts to RendererGLContext to check that it's always used on the same thread. Review URL: http://codereview.chromium.org/7713015 TBR=husky@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98395

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+66 lines, -117 lines)			Patch
M	content/renderer/gpu/renderer_gl_context.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	content/renderer/gpu/renderer_gl_context.cc	View	5 chunks	+1 line, -9 lines	0 comments	Download
M	content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.h	View	4 chunks	+0 lines, -16 lines	0 comments	Download
M	content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.cc	View	8 chunks	+65 lines, -88 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages