Reland 98392 - Split WebGraphicsContext3DCommandBufferImpl::initialize() into two stages.

Reland 98392 - Split WebGraphicsContext3DCommandBufferImpl::initialize() into two stages.

After the context is created, the remaining calls should be done on
the compositor thread. This CL adds a MaybeInitializeGL() method, which
we run on each call to makeContextCurrent().

Added asserts to RendererGLContext to check that it's always used on
the same thread.

Original review URL: http://codereview.chromium.org/7713015
Reverted due to buildbot errors: http://codereview.chromium.org/7745042
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99648

[lain Merrick, 2011-09-02 16:57:55]

Second attempt to land this CL. Not sure what went wrong last time, but I'll
make sure all the bots are happy this time before submitting.

Some minor updates to resolve conflicts, and a comment update requested by
jbates.

[jbates, 2011-09-02 17:02:02]

comments LGTM

[Ken Russell (switch to Gerrit), 2011-09-02 17:56:46]

LGTM

http://codereview.chromium.org/7828046/diff/1/content/renderer/gpu/webgraphic...
File content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.cc (right):

http://codereview.chromium.org/7828046/diff/1/content/renderer/gpu/webgraphic...
content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.cc:123:
TRACE_EVENT0("gpu", "WebGfxCtx3DCmdBfgImpl::MaybeInitializeGL");
Bfg?

[lain Merrick, 2011-09-05 10:37:53]

http://codereview.chromium.org/7828046/diff/1/content/renderer/gpu/webgraphic...
File content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.cc (right):

http://codereview.chromium.org/7828046/diff/1/content/renderer/gpu/webgraphic...
content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.cc:123:
TRACE_EVENT0("gpu", "WebGfxCtx3DCmdBfgImpl::MaybeInitializeGL");
On 2011/09/02 17:56:46, kbr wrote:
> Bfg?

Oops! Not a Doom reference, honest. Fixed.

[lain Merrick, 2011-09-05 13:44:08]

Well, I finally found out what caused that error! Stupid oversight -- the
DCHECKs don't compile in release mode. The try bots didn't catch this but the
build bots did.

Ken, I've TBR'd a fix on you - http://codereview.chromium.org/7834021/