Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7834048: Preliminary work to allow Chrome to build with USE_AURA (Closed)

Created:
9 years, 3 months ago by Ben Goodger (Google)
Modified:
9 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, yoshiki+watch_chromium.org, Erik does not do reviews, kkania, mihaip+watch_chromium.org, Aaron Boodman, Paweł Hajdan Jr.
Visibility:
Public.

Description

Preliminary work to allow Chrome to build with USE_AURA. This gets browser.lib to build. http://crbug.com/93947 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99787

Patch Set 1 : '' #

Total comments: 13

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+278 lines, -105 lines) Patch
M chrome/browser/automation/automation_provider.h View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/automation/automation_provider.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_drop_info.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_util.cc View 1 2 4 chunks +10 lines, -4 lines 0 comments Download
M chrome/browser/plugin_download_helper.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/plugin_installer_infobar_delegate.cc View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/themes/theme_service.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/input_window_dialog_win.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_view.cc View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc View 1 2 3 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/avatar_menu_button.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/ui/views/browser_bubble.cc View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/bubble/bubble.h View 1 2 6 chunks +15 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/bubble/bubble.cc View 1 2 13 chunks +42 lines, -14 lines 0 comments Download
M chrome/browser/ui/views/collected_cookies_win.cc View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/compact_nav/compact_location_bar_view_host.cc View 1 2 5 chunks +18 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/constrained_window_views.cc View 1 2 3 chunks +11 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_view.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/ui/views/find_bar_host.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_frame.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 25 chunks +33 lines, -26 lines 0 comments Download
M chrome/browser/ui/views/infobars/infobar_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M chrome/browser/ui/views/notifications/balloon_view_host.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/base_tab_strip.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/dragged_tab_controller.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/tabs/dragged_tab_view.cc View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/task_manager_view.cc View 1 2 4 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/advanced_options_utils_win.cc View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +57 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/automation_messages.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/automation_messages_internal.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/automation/tab_proxy.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Ben Goodger (Google)
9 years, 3 months ago (2011-09-06 17:01:08 UTC) #1
sky
9 years, 3 months ago (2011-09-06 17:22:48 UTC) #2 
LGTM

http://codereview.chromium.org/7834048/diff/31/chrome/browser/plugin_download...
File chrome/browser/plugin_download_helper.cc (right):

http://codereview.chromium.org/7834048/diff/31/chrome/browser/plugin_download...
chrome/browser/plugin_download_helper.cc:83: #endif  // OS_WIN
Update this too.

http://codereview.chromium.org/7834048/diff/31/chrome/browser/plugin_installe...
File chrome/browser/plugin_installer_infobar_delegate.cc (right):

http://codereview.chromium.org/7834048/diff/31/chrome/browser/plugin_installe...
chrome/browser/plugin_installer_infobar_delegate.cc:59: #endif  // OS_WIN
#else NOTIMPLEMENTED

http://codereview.chromium.org/7834048/diff/31/chrome/browser/themes/theme_se...
File chrome/browser/themes/theme_service.cc (right):

http://codereview.chromium.org/7834048/diff/31/chrome/browser/themes/theme_se...
chrome/browser/themes/theme_service.cc:276: return false;
NOTIMPLEMENTED?

http://codereview.chromium.org/7834048/diff/31/chrome/browser/ui/views/autoco...
File chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc
(right):

http://codereview.chromium.org/7834048/diff/31/chrome/browser/ui/views/autoco...
chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc:632:
#endif
#else NOTIMPLEMENTED

http://codereview.chromium.org/7834048/diff/31/chrome/browser/ui/views/avatar...
File chrome/browser/ui/views/avatar_menu_button.cc (right):

http://codereview.chromium.org/7834048/diff/31/chrome/browser/ui/views/avatar...
chrome/browser/ui/views/avatar_menu_button.cc:65: #endif
#else NOTIMPLEMNETED?

http://codereview.chromium.org/7834048/diff/31/chrome/browser/ui/views/bubble...
File chrome/browser/ui/views/bubble/bubble.cc (right):

http://codereview.chromium.org/7834048/diff/31/chrome/browser/ui/views/bubble...
chrome/browser/ui/views/bubble/bubble.cc:113: #elif defined(OS_WIN)
NOTIMPLEMENTED?

http://codereview.chromium.org/7834048/diff/31/chrome/browser/ui/views/bubble...
chrome/browser/ui/views/bubble/bubble.cc:403: #endif
#else NOTIMPLEMNETED?

http://codereview.chromium.org/7834048/diff/31/chrome/browser/ui/views/collec...
File chrome/browser/ui/views/collected_cookies_win.cc (right):

http://codereview.chromium.org/7834048/diff/31/chrome/browser/ui/views/collec...
chrome/browser/ui/views/collected_cookies_win.cc:507: #endif;
no ;

http://codereview.chromium.org/7834048/diff/31/chrome/browser/ui/views/constr...
File chrome/browser/ui/views/constrained_window_views.cc (right):

http://codereview.chromium.org/7834048/diff/31/chrome/browser/ui/views/constr...
chrome/browser/ui/views/constrained_window_views.cc:561: #endif
#else NOTIMPLEMENTED? Also, do we need to set title_font_?

http://codereview.chromium.org/7834048/diff/31/chrome/browser/ui/views/find_b...
File chrome/browser/ui/views/find_bar_host.cc (right):

http://codereview.chromium.org/7834048/diff/31/chrome/browser/ui/views/find_b...
chrome/browser/ui/views/find_bar_host.cc:204: // See bug http://crbug.com/28629.
NOTIMPLMENETED?

http://codereview.chromium.org/7834048/diff/31/chrome/browser/ui/views/task_m...
File chrome/browser/ui/views/task_manager_view.cc (right):

http://codereview.chromium.org/7834048/diff/31/chrome/browser/ui/views/task_m...
chrome/browser/ui/views/task_manager_view.cc:643: #endif
#else NOTIMPLEMENTED?

http://codereview.chromium.org/7834048/diff/31/chrome/browser/ui/views/task_m...
chrome/browser/ui/views/task_manager_view.cc:770: #endif
#else NOTIMPLEMENTED?

http://codereview.chromium.org/7834048/diff/31/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

http://codereview.chromium.org/7834048/diff/31/chrome/chrome_browser.gypi#new...
chrome/chrome_browser.gypi:3958: ['exclude',
'^browser/ui/tabs/dock_info_win.cc'],
nit: sort these.

Powered by Google App Engine
This is Rietveld 408576698