Added check for trailing whitespaces and corrected existing violations.

Added check for trailing whitespaces and corrected existing violations.

Committed: http://code.google.com/p/v8/source/detail?r=9094

[Yang, 2011-09-01 09:12:53]

All changes except for tools/presubmit.py are automated. PTAL.

[Jakob Kummerow, 2011-09-01 09:29:46]

http://codereview.chromium.org/7826007/diff/1/benchmarks/earley-boyer.js
File benchmarks/earley-boyer.js (right):

http://codereview.chromium.org/7826007/diff/1/benchmarks/earley-boyer.js#newc...
benchmarks/earley-boyer.js:2432: 
Is this a \t ?!

http://codereview.chromium.org/7826007/diff/1/benchmarks/earley-boyer.js#newc...
benchmarks/earley-boyer.js:3075: 
Another \t

http://codereview.chromium.org/7826007/diff/1/test/mjsunit/string-compare-ali...
File test/mjsunit/string-compare-alignment.js (right):

http://codereview.chromium.org/7826007/diff/1/test/mjsunit/string-compare-ali...
test/mjsunit/string-compare-alignment.js:32: var base = "Now is the time for all
good men to come to the aid of the party. " +
While you're at it, fix the line length to 80 chars.

http://codereview.chromium.org/7826007/diff/1/tools/presubmit.py
File tools/presubmit.py (right):

http://codereview.chromium.org/7826007/diff/1/tools/presubmit.py#newcode3
tools/presubmit.py:3: # Copyright 2008 the V8 project authors. All rights
reserved.
2011

http://codereview.chromium.org/7826007/diff/1/tools/presubmit.py#newcode234
tools/presubmit.py:234: Check that all files include a copyright notice and
trailing whitespaces.
you mean "and *no* trailing whitespace", right?

http://codereview.chromium.org/7826007/diff/1/tools/presubmit.py#newcode276
tools/presubmit.py:276: if ' \n' in contents or contents.endswith(' '):
The "contents.endswith(' ')" case isn't handled below.

[Kevin Millikin (Chromium), 2011-09-01 09:32:21]

http://codereview.chromium.org/7826007/diff/1/tools/presubmit.py
File tools/presubmit.py (right):

http://codereview.chromium.org/7826007/diff/1/tools/presubmit.py#newcode284
tools/presubmit.py:284: print "%s has trailing whitespaces in lines: %s" %
(name, linenumbers)
There is already a check for trailing whitespace for C++ files, so won't we now
get two warnings for C++ files?  You might consider disabling
whitespace/end_of_line.

[Yang, 2011-09-01 09:46:19]

Applied suggestions. Take another look please.

[Kevin Millikin (Chromium), 2011-09-01 10:07:12]

http://codereview.chromium.org/7826007/diff/149/tools/presubmit.py
File tools/presubmit.py (right):

http://codereview.chromium.org/7826007/diff/149/tools/presubmit.py#newcode91
tools/presubmit.py:91: whitespace/end_of_line
It's simpler to just delete this line than IGNORE_TRAILING_WHITESPACE_EXTENSIONS
below.  That way we'll also get the same warning message for all violations.

[Yang, 2011-09-01 10:54:35]

Applied Kevin's suggestion and updated build/all.gyp that had slightly different
copyright header than the presubmit script liked.

[Jakob Kummerow, 2011-09-01 11:12:04]

LGTM