Added check for trailing whitespaces and corrected existing violations.

tools/presubmit.py

 #!/usr/bin/env python
 #
 # Copyright 2008 the V8 project authors. All rights reserved.

[Jakob Kummerow, 2011/09/01 09:29:46]

2011

 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 #       notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 #       copyright notice, this list of conditions and the following
 #       disclaimer in the documentation and/or other materials provided
 #       with the distribution.
@@ skipping 210 matching lines @@
 
     good_files_cache.Save()
     return process.returncode == 0
 
 
 COPYRIGHT_HEADER_PATTERN = re.compile(
     r'Copyright [\d-]*20[0-1][0-9] the V8 project authors. All rights reserved.')
 
 class SourceProcessor(SourceFileProcessor):
   """
-  Check that all files include a copyright notice.
+  Check that all files include a copyright notice and trailing whitespaces.

[Jakob Kummerow, 2011/09/01 09:29:46]

you mean "and *no* trailing whitespace", right?

   """
 
   RELEVANT_EXTENSIONS = ['.js', '.cc', '.h', '.py', '.c', 'SConscript',
-      'SConstruct', '.status']
+      'SConstruct', '.status', '.gyp', '.gypi']
   def IsRelevant(self, name):
     for ext in SourceProcessor.RELEVANT_EXTENSIONS:
       if name.endswith(ext):
         return True
     return False
 
   def GetPathsToSearch(self):
     return ['.']
 
   def IgnoreDir(self, name):
@@ skipping 17 matching lines @@
     result = True
     base = basename(name)
     if not base in SourceProcessor.IGNORE_TABS:
       if '\t' in contents:
         print "%s contains tabs" % name
         result = False
     if not base in SourceProcessor.IGNORE_COPYRIGHTS:
       if not COPYRIGHT_HEADER_PATTERN.search(contents):
         print "%s is missing a correct copyright header." % name
         result = False
+    if ' \n' in contents or contents.endswith(' '):

[Jakob Kummerow, 2011/09/01 09:29:46]

The "contents.endswith(' ')" case isn't handled below.

+      line = 0
+      lines = []
+      for part in contents.split(' \n')[0:-1]:
+        line += part.count('\n') + 1;
+        lines.append(str(line));
+      linenumbers = ', '.join(lines);
+      if len(lines) > 1:
+        print "%s has trailing whitespaces in lines: %s" % (name, linenumbers)

[Kevin Millikin (Chromium), 2011/09/01 09:32:21]

There is already a check for trailing whitespace for C++ files, so won't we now
get two warnings for C++ files?  You might consider disabling
whitespace/end_of_line.

+      else:
+        print "%s has trailing whitespaces in line %s" % (name, linenumbers)
+      result = False
     return result
 
   def ProcessFiles(self, files, path):
     success = True
     for file in files:
       try:
         handle = open(file)
         contents = handle.read()
         success = self.ProcessContents(file, contents) and success
       finally:
@@ skipping 17 matching lines @@
     success = CppLintProcessor().Run(workspace) and success
   success = SourceProcessor().Run(workspace) and success
   if success:
     return 0
   else:
     return 1
 
 
 if __name__ == '__main__':
   sys.exit(Main())