Added check for trailing whitespaces and corrected existing violations.

tools/presubmit.py

 #!/usr/bin/env python
 #
-# Copyright 2008 the V8 project authors. All rights reserved.
+# Copyright 2011 the V8 project authors. All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 #       notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 #       copyright notice, this list of conditions and the following
 #       disclaimer in the documentation and/or other materials provided
 #       with the distribution.
@@ skipping 67 matching lines @@
 runtime/references
 runtime/rtti
 runtime/sizeof
 runtime/string
 runtime/virtual
 runtime/vlog
 whitespace/blank_line
 whitespace/braces
 whitespace/comma
 whitespace/comments
 whitespace/end_of_line

[Kevin Millikin (Chromium), 2011/09/01 10:07:12]

It's simpler to just delete this line than IGNORE_TRAILING_WHITESPACE_EXTENSIONS
below.  That way we'll also get the same warning message for all violations.

 whitespace/ending_newline
 whitespace/indent
 whitespace/labels
 whitespace/line_length
 whitespace/newline
 whitespace/operators
 whitespace/parens
 whitespace/tab
 whitespace/todo
 """.split()
@@ skipping 122 matching lines @@
 
     good_files_cache.Save()
     return process.returncode == 0
 
 
 COPYRIGHT_HEADER_PATTERN = re.compile(
     r'Copyright [\d-]*20[0-1][0-9] the V8 project authors. All rights reserved.')
 
 class SourceProcessor(SourceFileProcessor):
   """
-  Check that all files include a copyright notice.
+  Check that all files include a copyright notice and no trailing whitespaces.
   """
 
   RELEVANT_EXTENSIONS = ['.js', '.cc', '.h', '.py', '.c', 'SConscript',
-      'SConstruct', '.status']
+      'SConstruct', '.status', '.gyp', '.gypi']
+  IGNORE_TRAILING_WHITESPACE_EXTENSIONS = ['.c', '.cc', '.h']
+
   def IsRelevant(self, name):
     for ext in SourceProcessor.RELEVANT_EXTENSIONS:
       if name.endswith(ext):
         return True
     return False
 
   def GetPathsToSearch(self):
     return ['.']
 
   def IgnoreDir(self, name):
@@ skipping 17 matching lines @@
     result = True
     base = basename(name)
     if not base in SourceProcessor.IGNORE_TABS:
       if '\t' in contents:
         print "%s contains tabs" % name
         result = False
     if not base in SourceProcessor.IGNORE_COPYRIGHTS:
       if not COPYRIGHT_HEADER_PATTERN.search(contents):
         print "%s is missing a correct copyright header." % name
         result = False
+    ext = base.split('.').pop()
+    if not ext in SourceProcessor.IGNORE_TRAILING_WHITESPACE_EXTENSIONS and  \
+        ' \n' in contents or contents.endswith(' '):
+      line = 0
+      lines = []
+      parts = contents.split(' \n')
+      if not contents.endswith(' '):
+        parts.pop()
+      for part in parts:
+        line += part.count('\n') + 1
+        lines.append(str(line))
+      linenumbers = ', '.join(lines)
+      if len(lines) > 1:
+        print "%s has trailing whitespaces in lines: %s" % (name, linenumbers)
+      else:
+        print "%s has trailing whitespaces in line %s" % (name, linenumbers)
+      result = False
     return result
 
   def ProcessFiles(self, files, path):
     success = True
     for file in files:
       try:
         handle = open(file)
         contents = handle.read()
         success = self.ProcessContents(file, contents) and success
       finally:
@@ skipping 17 matching lines @@
     success = CppLintProcessor().Run(workspace) and success
   success = SourceProcessor().Run(workspace) and success
   if success:
     return 0
   else:
     return 1
 
 
 if __name__ == '__main__':
   sys.exit(Main())