Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 7822008: [Sync] Remove static initializers (Closed)

Created:
9 years, 3 months ago by akalin
Modified:
9 years, 3 months ago
CC:
chromium-reviews, Raghu Simha, ncarter (slow), idana, tim (not reviewing), Paweł Hajdan Jr.
Visibility:
Public.

Description

[Sync] Remove static initializers BUG=94991 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99139

Patch Set 1 #

Patch Set 2 : Sync to head #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -90 lines) Patch
M chrome/browser/sync/engine/apply_updates_command_unittest.cc View 1 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sync/engine/build_and_process_conflict_sets_command.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/engine/build_commit_command.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/engine/build_commit_command.cc View 4 chunks +20 lines, -13 lines 0 comments Download
M chrome/browser/sync/engine/build_commit_command_unittest.cc View 2 chunks +48 lines, -42 lines 0 comments Download
M chrome/browser/sync/engine/conflict_resolver.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/engine/syncer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/engine/syncer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/engine/syncer_util.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/engine/verify_updates_command_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/internal_api/syncapi_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/notifier/cache_invalidation_packet_handler.cc View 3 chunks +20 lines, -16 lines 0 comments Download
M chrome/browser/sync/syncable/syncable_id.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/syncable/syncable_id.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
akalin
+zea for review
9 years, 3 months ago (2011-09-01 00:11:24 UTC) #1
Nicolas Zea
LGTM
9 years, 3 months ago (2011-09-01 00:29:11 UTC) #2
commit-bot: I haz the power
Can't apply patch for file chrome/browser/sync/engine/apply_updates_command_unittest.cc. While running patch -p1 --forward --force; patching file chrome/browser/sync/engine/apply_updates_command_unittest.cc ...
9 years, 3 months ago (2011-09-01 01:18:23 UTC) #3
commit-bot: I haz the power
9 years, 3 months ago (2011-09-01 06:15:46 UTC) #4
Change committed as 99139

Powered by Google App Engine
This is Rietveld 408576698