Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: chrome/browser/sync/engine/apply_updates_command_unittest.cc

Issue 7822008: [Sync] Remove static initializers (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sync to head Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/sync/engine/build_and_process_conflict_sets_command.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/engine/apply_updates_command_unittest.cc
diff --git a/chrome/browser/sync/engine/apply_updates_command_unittest.cc b/chrome/browser/sync/engine/apply_updates_command_unittest.cc
index 8fd8ee2b01c43f3c404cef4b7ff94baec57bd603..aa32c71720fad6fe49c5bdafe660adeed59fac71 100644
--- a/chrome/browser/sync/engine/apply_updates_command_unittest.cc
+++ b/chrome/browser/sync/engine/apply_updates_command_unittest.cc
@@ -92,7 +92,7 @@ class ApplyUpdatesCommandTest : public SyncerCommandTest {
entry.Put(syncable::SERVER_VERSION, next_revision_++);
entry.Put(syncable::IS_UNAPPLIED_UPDATE, true);
entry.Put(syncable::SERVER_NON_UNIQUE_NAME, item_id);
- entry.Put(syncable::SERVER_PARENT_ID, syncable::kNullId);
+ entry.Put(syncable::SERVER_PARENT_ID, syncable::GetNullId());
entry.Put(syncable::SERVER_IS_DIR, false);
entry.Put(syncable::SERVER_SPECIFICS, specifics);
if (is_unique) // For top-level nodes.
@@ -144,7 +144,7 @@ class ApplyUpdatesCommandTest : public SyncerCommandTest {
};
TEST_F(ApplyUpdatesCommandTest, Simple) {
- string root_server_id = syncable::kNullId.GetServerId();
+ string root_server_id = syncable::GetNullId().GetServerId();
CreateUnappliedNewItemWithParent("parent",
DefaultBookmarkSpecifics(),
root_server_id);
@@ -168,7 +168,7 @@ TEST_F(ApplyUpdatesCommandTest, Simple) {
TEST_F(ApplyUpdatesCommandTest, UpdateWithChildrenBeforeParents) {
// Set a bunch of updates which are difficult to apply in the order
// they're received due to dependencies on other unseen items.
- string root_server_id = syncable::kNullId.GetServerId();
+ string root_server_id = syncable::GetNullId().GetServerId();
CreateUnappliedNewItemWithParent("a_child_created_first",
DefaultBookmarkSpecifics(),
"parent");
@@ -220,7 +220,7 @@ TEST_F(ApplyUpdatesCommandTest, NestedItemsWithUnknownParent) {
TEST_F(ApplyUpdatesCommandTest, ItemsBothKnownAndUnknown) {
// See what happens when there's a mixture of good and bad updates.
- string root_server_id = syncable::kNullId.GetServerId();
+ string root_server_id = syncable::GetNullId().GetServerId();
CreateUnappliedNewItemWithParent("first_unknown_item",
DefaultBookmarkSpecifics(),
"unknown_parent");
@@ -293,7 +293,7 @@ TEST_F(ApplyUpdatesCommandTest, UndecryptableData) {
sync_pb::EntitySpecifics encrypted_bookmark;
encrypted_bookmark.mutable_encrypted();
AddDefaultExtensionValue(syncable::BOOKMARKS, &encrypted_bookmark);
- string root_server_id = syncable::kNullId.GetServerId();
+ string root_server_id = syncable::GetNullId().GetServerId();
CreateUnappliedNewItemWithParent("folder",
encrypted_bookmark,
root_server_id);
« no previous file with comments | « no previous file | chrome/browser/sync/engine/build_and_process_conflict_sets_command.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698