Print Preview: Populating print preview tab title as soon as it is known.

Print Preview: Populating print preview tab title as soon as it is known.

After http://src.chromium.org/viewvc/chrome?view=rev&revision=97284 the title is populated when the total page count is received. We can still do it  a bit earlier (from within onLoad()).

BUG=92428
TEST=See bug description.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99849

[kmadhusu, 2011-09-02 06:50:09]

http://codereview.chromium.org/7818010/diff/2001/chrome/browser/resources/pri...
File chrome/browser/resources/print_preview/print_preview.js (right):

http://codereview.chromium.org/7818010/diff/2001/chrome/browser/resources/pri...
chrome/browser/resources/print_preview/print_preview.js:140:
chrome.send('getInitiatorTabTitle');
What will be the title if the initiator tab is closed and the preview tab is
reloaded?

[dpapad, 2011-09-02 17:40:18]

http://codereview.chromium.org/7818010/diff/2001/chrome/browser/resources/pri...
File chrome/browser/resources/print_preview/print_preview.js (right):

http://codereview.chromium.org/7818010/diff/2001/chrome/browser/resources/pri...
chrome/browser/resources/print_preview/print_preview.js:140:
chrome.send('getInitiatorTabTitle');
On 2011/09/02 06:50:09, kmadhusu wrote:
> What will be the title if the initiator tab is closed and the preview tab is
> reloaded?

It was displaying "Print -", fixed now to display "Print".

[kmadhusu, 2011-09-02 18:50:20]

http://codereview.chromium.org/7818010/diff/8001/chrome/browser/ui/webui/prin...
File chrome/browser/ui/webui/print_preview_handler.cc (right):

http://codereview.chromium.org/7818010/diff/8001/chrome/browser/ui/webui/prin...
chrome/browser/ui/webui/print_preview_handler.cc:748: void
PrintPreviewHandler::HandleGetInitiatorTabTitle(const ListValue* args) {
args is unused. you can remove that.

http://codereview.chromium.org/7818010/diff/8001/chrome/browser/ui/webui/prin...
File chrome/browser/ui/webui/print_preview_ui.h (right):

http://codereview.chromium.org/7818010/diff/8001/chrome/browser/ui/webui/prin...
chrome/browser/ui/webui/print_preview_ui.h:52: void OnGetInitiatorTabTitle();
Can you rename this function to SendInitiatorTabTitle()?

[dpapad, 2011-09-03 00:10:29]

http://codereview.chromium.org/7818010/diff/8001/chrome/browser/ui/webui/prin...
File chrome/browser/ui/webui/print_preview_handler.cc (right):

http://codereview.chromium.org/7818010/diff/8001/chrome/browser/ui/webui/prin...
chrome/browser/ui/webui/print_preview_handler.cc:748: void
PrintPreviewHandler::HandleGetInitiatorTabTitle(const ListValue* args) {
On 2011/09/02 18:50:20, kmadhusu wrote:
> args is unused. you can remove that.

This is used with RegisterMessageCallback(), I can't remove |args|, right? This
is what other Handle*** methods do in that file.

http://codereview.chromium.org/7818010/diff/8001/chrome/browser/ui/webui/prin...
File chrome/browser/ui/webui/print_preview_ui.h (right):

http://codereview.chromium.org/7818010/diff/8001/chrome/browser/ui/webui/prin...
chrome/browser/ui/webui/print_preview_ui.h:52: void OnGetInitiatorTabTitle();
On 2011/09/02 18:50:20, kmadhusu wrote:
> Can you rename this function to SendInitiatorTabTitle()?

Done.

[kmadhusu1, 2011-09-03 00:17:30]

On Fri, Sep 2, 2011 at 5:10 PM, <dpapad@chromium.org> wrote:

>
> http://codereview.chromium.**org/7818010/diff/8001/chrome/**
>
browser/ui/webui/print_**preview_handler.cc<http://codereview.chromium.org/7818010/diff/8001/chrome/browser/ui/webui/print_preview_handler.cc>
> File chrome/browser/ui/webui/print_**preview_handler.cc (right):
>
> http://codereview.chromium.**org/7818010/diff/8001/chrome/**
>
browser/ui/webui/print_**preview_handler.cc#newcode748<http://codereview.chromium.org/7818010/diff/8001/chrome/browser/ui/webui/print_preview_handler.cc#newcode748>
> chrome/browser/ui/webui/print_**preview_handler.cc:748: void
> PrintPreviewHandler::**HandleGetInitiatorTabTitle(**const ListValue* args)
> {
> On 2011/09/02 18:50:20, kmadhusu wrote:
>
>> args is unused. you can remove that.
>>
>
> This is used with RegisterMessageCallback(), I can't remove |args|,
> right? This is what other Handle*** methods do in that file.
>
> I meant (ListValue*)

>
> http://codereview.chromium.**org/7818010/diff/8001/chrome/**
>
browser/ui/webui/print_**preview_ui.h<http://codereview.chromium.org/7818010/diff/8001/chrome/browser/ui/webui/print_preview_ui.h>
> File chrome/browser/ui/webui/print_**preview_ui.h (right):
>
> http://codereview.chromium.**org/7818010/diff/8001/chrome/**
>
browser/ui/webui/print_**preview_ui.h#newcode52<http://codereview.chromium.org/7818010/diff/8001/chrome/browser/ui/webui/print_preview_ui.h#newcode52>
> chrome/browser/ui/webui/print_**preview_ui.h:52: void
> OnGetInitiatorTabTitle();
> On 2011/09/02 18:50:20, kmadhusu wrote:
>
>> Can you rename this function to SendInitiatorTabTitle()?
>>
>
> Done.
>
>
>
http://codereview.chromium.**org/7818010/<http://codereview.chromium.org/7818...
>

[dpapad, 2011-09-06 17:07:18]

http://codereview.chromium.org/7818010/diff/14004/chrome/browser/ui/webui/pri...
File chrome/browser/ui/webui/print_preview_handler.cc (right):

http://codereview.chromium.org/7818010/diff/14004/chrome/browser/ui/webui/pri...
chrome/browser/ui/webui/print_preview_handler.cc:771: const ListValue* /*args*/)
{
Using this format for unused parameters according to the styleguide
(http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Functi...).

[kmadhusu, 2011-09-06 18:19:32]

LGTM with a nit.

http://codereview.chromium.org/7818010/diff/14004/chrome/browser/ui/webui/pri...
File chrome/browser/ui/webui/print_preview_handler.cc (right):

http://codereview.chromium.org/7818010/diff/14004/chrome/browser/ui/webui/pri...
chrome/browser/ui/webui/print_preview_handler.cc:771: const ListValue* /*args*/)
{
On 2011/09/06 17:07:19, dpapad wrote:
> Using this format for unused parameters according to the styleguide
>
(http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Functi...).

In this file, we don't follow that style in other function definitions.  It will
be better if this function signature is consistent with others.

[dpapad, 2011-09-06 21:27:51]

http://codereview.chromium.org/7818010/diff/14004/chrome/browser/ui/webui/pri...
File chrome/browser/ui/webui/print_preview_handler.cc (right):

http://codereview.chromium.org/7818010/diff/14004/chrome/browser/ui/webui/pri...
chrome/browser/ui/webui/print_preview_handler.cc:771: const ListValue* /*args*/)
{
On 2011/09/06 18:19:32, kmadhusu wrote:
> On 2011/09/06 17:07:19, dpapad wrote:
> > Using this format for unused parameters according to the styleguide
> >
>
(http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Functi...).
> 
> In this file, we don't follow that style in other function definitions.  It
will
> be better if this function signature is consistent with others.

I changed all the method signatures (with unused parameters) to follow the
styleguide.

[kmadhusu, 2011-09-06 22:19:12]

LGTM