Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3839)

Unified Diff: chrome/browser/ui/webui/print_preview_ui.cc

Issue 7818010: Print Preview: Populating print preview tab title as soon as it is known. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing unused parameters style Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/print_preview_ui.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/print_preview_ui.cc
diff --git a/chrome/browser/ui/webui/print_preview_ui.cc b/chrome/browser/ui/webui/print_preview_ui.cc
index 71820709f3a3b47006130e5297db3ab5d4dff88d..24e4f29b0cd18bc3fdc3e74f5036473f198f0e38 100644
--- a/chrome/browser/ui/webui/print_preview_ui.cc
+++ b/chrome/browser/ui/webui/print_preview_ui.cc
@@ -116,6 +116,11 @@ void PrintPreviewUI::SetInitiatorTabURLAndTitle(
initiator_tab_title_ = job_title;
}
+void PrintPreviewUI::SendInitiatorTabTitle() {
+ base::StringValue tab_title(initiator_tab_title_);
+ CallJavascriptFunction("setInitiatorTabTitle", tab_title);
+}
+
// static
void PrintPreviewUI::GetCurrentPrintPreviewStatus(
const std::string& preview_ui_addr,
@@ -161,9 +166,8 @@ void PrintPreviewUI::OnDidGetPreviewPageCount(
base::FundamentalValue count(params.page_count);
base::FundamentalValue modifiable(params.is_modifiable);
base::FundamentalValue request_id(params.preview_request_id);
- StringValue title(initiator_tab_title_);
CallJavascriptFunction("onDidGetPreviewPageCount", count, modifiable,
- request_id, title);
+ request_id);
}
void PrintPreviewUI::OnDidGetDefaultPageLayout(
« no previous file with comments | « chrome/browser/ui/webui/print_preview_ui.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698