Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Side by Side Diff: chrome/browser/ui/webui/print_preview_handler.cc

Issue 7818010: Print Preview: Populating print preview tab title as soon as it is known. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing corner case Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/print_preview_handler.h" 5 #include "chrome/browser/ui/webui/print_preview_handler.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/base64.h" 9 #include "base/base64.h"
10 #if !defined(OS_CHROMEOS) 10 #if !defined(OS_CHROMEOS)
(...skipping 428 matching lines...) Expand 10 before | Expand all | Expand 10 after
439 web_ui_->RegisterMessageCallback("reloadCrashedInitiatorTab", 439 web_ui_->RegisterMessageCallback("reloadCrashedInitiatorTab",
440 NewCallback(this, &PrintPreviewHandler::HandleReloadCrashedInitiatorTab)); 440 NewCallback(this, &PrintPreviewHandler::HandleReloadCrashedInitiatorTab));
441 web_ui_->RegisterMessageCallback("closePrintPreviewTab", 441 web_ui_->RegisterMessageCallback("closePrintPreviewTab",
442 NewCallback(this, &PrintPreviewHandler::HandleClosePreviewTab)); 442 NewCallback(this, &PrintPreviewHandler::HandleClosePreviewTab));
443 web_ui_->RegisterMessageCallback("hidePreview", 443 web_ui_->RegisterMessageCallback("hidePreview",
444 NewCallback(this, &PrintPreviewHandler::HandleHidePreview)); 444 NewCallback(this, &PrintPreviewHandler::HandleHidePreview));
445 web_ui_->RegisterMessageCallback("cancelPendingPrintRequest", 445 web_ui_->RegisterMessageCallback("cancelPendingPrintRequest",
446 NewCallback(this, &PrintPreviewHandler::HandleCancelPendingPrintRequest)); 446 NewCallback(this, &PrintPreviewHandler::HandleCancelPendingPrintRequest));
447 web_ui_->RegisterMessageCallback("saveLastPrinter", 447 web_ui_->RegisterMessageCallback("saveLastPrinter",
448 NewCallback(this, &PrintPreviewHandler::HandleSaveLastPrinter)); 448 NewCallback(this, &PrintPreviewHandler::HandleSaveLastPrinter));
449 web_ui_->RegisterMessageCallback("getInitiatorTabTitle",
450 NewCallback(this, &PrintPreviewHandler::HandleGetInitiatorTabTitle));
449 } 451 }
450 452
451 TabContentsWrapper* PrintPreviewHandler::preview_tab_wrapper() const { 453 TabContentsWrapper* PrintPreviewHandler::preview_tab_wrapper() const {
452 return TabContentsWrapper::GetCurrentWrapperForContents(preview_tab()); 454 return TabContentsWrapper::GetCurrentWrapperForContents(preview_tab());
453 } 455 }
454 TabContents* PrintPreviewHandler::preview_tab() const { 456 TabContents* PrintPreviewHandler::preview_tab() const {
455 return web_ui_->tab_contents(); 457 return web_ui_->tab_contents();
456 } 458 }
457 459
458 void PrintPreviewHandler::HandleGetDefaultPrinter(const ListValue*) { 460 void PrintPreviewHandler::HandleGetDefaultPrinter(const ListValue*) {
(...skipping 277 matching lines...) Expand 10 before | Expand all | Expand 10 after
736 regenerate_preview_request_count_); 738 regenerate_preview_request_count_);
737 739
738 ActivateInitiatorTabAndClosePreviewTab(); 740 ActivateInitiatorTabAndClosePreviewTab();
739 } 741 }
740 742
741 void PrintPreviewHandler::ReportStats() { 743 void PrintPreviewHandler::ReportStats() {
742 UMA_HISTOGRAM_COUNTS("PrintPreview.ManagePrinters", 744 UMA_HISTOGRAM_COUNTS("PrintPreview.ManagePrinters",
743 manage_printers_dialog_request_count_); 745 manage_printers_dialog_request_count_);
744 } 746 }
745 747
748 void PrintPreviewHandler::HandleGetInitiatorTabTitle(const ListValue* args) {
kmadhusu 2011/09/02 18:50:20 args is unused. you can remove that.
dpapad 2011/09/03 00:10:29 This is used with RegisterMessageCallback(), I can
749 PrintPreviewUI* print_preview_ui = static_cast<PrintPreviewUI*>(web_ui_);
750 print_preview_ui->OnGetInitiatorTabTitle();
751 }
752
746 void PrintPreviewHandler::ActivateInitiatorTabAndClosePreviewTab() { 753 void PrintPreviewHandler::ActivateInitiatorTabAndClosePreviewTab() {
747 TabContentsWrapper* initiator_tab = GetInitiatorTab(); 754 TabContentsWrapper* initiator_tab = GetInitiatorTab();
748 if (initiator_tab) { 755 if (initiator_tab) {
749 static_cast<RenderViewHostDelegate*>( 756 static_cast<RenderViewHostDelegate*>(
750 initiator_tab->tab_contents())->Activate(); 757 initiator_tab->tab_contents())->Activate();
751 } 758 }
752 ClosePrintPreviewTab(); 759 ClosePrintPreviewTab();
753 } 760 }
754 761
755 void PrintPreviewHandler::SendPrinterCapabilities( 762 void PrintPreviewHandler::SendPrinterCapabilities(
(...skipping 213 matching lines...) Expand 10 before | Expand all | Expand 10 after
969 return; 976 return;
970 977
971 // We no longer require the initiator tab details. Remove those details 978 // We no longer require the initiator tab details. Remove those details
972 // associated with the preview tab to allow the initiator tab to create 979 // associated with the preview tab to allow the initiator tab to create
973 // another preview tab. 980 // another preview tab.
974 printing::PrintPreviewTabController* tab_controller = 981 printing::PrintPreviewTabController* tab_controller =
975 printing::PrintPreviewTabController::GetInstance(); 982 printing::PrintPreviewTabController::GetInstance();
976 if (tab_controller) 983 if (tab_controller)
977 tab_controller->EraseInitiatorTabInfo(preview_tab_wrapper()); 984 tab_controller->EraseInitiatorTabInfo(preview_tab_wrapper());
978 } 985 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698