Break TYPE_PC into TYPE_WIN, TYPE_MAC, TYPE_LINUX.

Break TYPE_PC into TYPE_WIN, TYPE_MAC, TYPE_LINUX.

This can give us flexibility down the line with ui changes. No clients use the protocol yet so it's safe to move CrOs from 2 to 4.

BUG=94693
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98984

[Nicolas Zea, 2011-08-30 20:28:55]

LGTM

[ncarter (slow), 2011-08-30 21:52:30]

http://codereview.chromium.org/7811001/diff/2001/chrome/browser/sync/protocol...
File chrome/browser/sync/protocol/session_specifics.proto (right):

http://codereview.chromium.org/7811001/diff/2001/chrome/browser/sync/protocol...
chrome/browser/sync/protocol/session_specifics.proto:37: TYPE_OTHER = 5;
Why do the dangerous renumbering?

[Yaron, 2011-08-30 21:58:46]

http://codereview.chromium.org/7811001/diff/2001/chrome/browser/sync/protocol...
File chrome/browser/sync/protocol/session_specifics.proto (right):

http://codereview.chromium.org/7811001/diff/2001/chrome/browser/sync/protocol...
chrome/browser/sync/protocol/session_specifics.proto:37: TYPE_OTHER = 5;
On 2011/08/30 21:52:30, ncarter wrote:
> Why do the dangerous renumbering?

This field was just added and has never been used anywhere. There's no code yet
that reads/writes it.

[ncarter (slow), 2011-08-30 21:59:48]

http://codereview.chromium.org/7811001/diff/2001/chrome/browser/sync/protocol...
File chrome/browser/sync/protocol/session_specifics.proto (right):

http://codereview.chromium.org/7811001/diff/2001/chrome/browser/sync/protocol...
chrome/browser/sync/protocol/session_specifics.proto:37: TYPE_OTHER = 5;
On 2011/08/30 21:58:46, Yaron wrote:
> On 2011/08/30 21:52:30, ncarter wrote:
> > Why do the dangerous renumbering?
> 
> This field was just added and has never been used anywhere. There's no code
yet
> that reads/writes it.

OK.

[commit-bot: I haz the power, 2011-08-31 01:19:43]

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is linux, revision is 98905, job name
was 7811001-2001 (retry) (retry) (retry) (retry).

[Yaron, 2011-08-31 01:47:35]

On 2011/08/31 01:19:43, I haz the power (commit-bot) wrote:
> The commit queue went berserk retrying too often for a
> seemingly flaky test. Builder is linux, revision is 98905, job name
> was 7811001-2001 (retry) (retry) (retry) (retry).

I see that the commit checkbox isn't checked anymore. Should I try again later?

[Nicolas Zea, 2011-08-31 01:48:52]

The tree was having issues earlier, which may have been the reason for the
commit queue having problems. I'd probably give it another shot

On Tue, Aug 30, 2011 at 6:47 PM, <yfriedman@chromium.org> wrote:

> On 2011/08/31 01:19:43, I haz the power (commit-bot) wrote:
>
>> The commit queue went berserk retrying too often for a
>> seemingly flaky test. Builder is linux, revision is 98905, job name
>> was 7811001-2001 (retry) (retry) (retry) (retry).
>>
>
> I see that the commit checkbox isn't checked anymore. Should I try again
> later?
>
>
>
http://codereview.chromium.**org/7811001/<http://codereview.chromium.org/7811...
>

[commit-bot: I haz the power, 2011-08-31 16:34:47]

Change committed as 98984