chrome/browser/sync/protocol/proto_enum_conversions.cc - Issue 7811001: Break TYPE_PC into TYPE_WIN, TYPE_MAC, TYPE_LINUX.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/protocol/proto_enum_conversions.cc

Issue 7811001: Break TYPE_PC into TYPE_WIN, TYPE_MAC, TYPE_LINUX. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Add TYPE_OTHER Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/protocol/proto_enum_conversions.cc

diff --git a/chrome/browser/sync/protocol/proto_enum_conversions.cc b/chrome/browser/sync/protocol/proto_enum_conversions.cc

index d22dfaafb3ec6c114a2386d46e66968fafef15e7..7cb95ad9ce3ddf60fe3b11c3765fc2943e5bf1b1 100644

--- a/chrome/browser/sync/protocol/proto_enum_conversions.cc

+++ b/chrome/browser/sync/protocol/proto_enum_conversions.cc

@@ -91,10 +91,13 @@ const char* GetUpdatesSourceString(

const char* GetDeviceTypeString(

sync_pb::SessionHeader::DeviceType device_type) {

- ASSERT_ENUM_BOUNDS(sync_pb::SessionHeader, DeviceType, TYPE_PC, TYPE_CROS);

+ ASSERT_ENUM_BOUNDS(sync_pb::SessionHeader, DeviceType, TYPE_WIN, TYPE_OTHER);

switch (device_type) {

- ENUM_CASE(sync_pb::SessionHeader, TYPE_PC);

+ ENUM_CASE(sync_pb::SessionHeader, TYPE_WIN);

+ ENUM_CASE(sync_pb::SessionHeader, TYPE_MAC);

+ ENUM_CASE(sync_pb::SessionHeader, TYPE_LINUX);

ENUM_CASE(sync_pb::SessionHeader, TYPE_CROS);

+ ENUM_CASE(sync_pb::SessionHeader, TYPE_OTHER);

}

NOTREACHED();

return "";