Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: chrome/browser/sync/protocol/session_specifics.proto

Issue 7811001: Break TYPE_PC into TYPE_WIN, TYPE_MAC, TYPE_LINUX. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Add TYPE_OTHER Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/sync/protocol/proto_enum_conversions.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Sync protocol datatype extension for sessions. 5 // Sync protocol datatype extension for sessions.
6 6
7 // Update proto_value_conversions{.h,.cc,_unittest.cc} if you change 7 // Update proto_value_conversions{.h,.cc,_unittest.cc} if you change
8 // any fields in this file. 8 // any fields in this file.
9 9
10 syntax = "proto2"; 10 syntax = "proto2";
(...skipping 12 matching lines...) Expand all
23 optional SessionTab tab = 3; 23 optional SessionTab tab = 3;
24 } 24 }
25 // Properties of session sync objects. 25 // Properties of session sync objects.
26 message SessionHeader { 26 message SessionHeader {
27 // Each session is composed of windows. 27 // Each session is composed of windows.
28 repeated SessionWindow window = 2; 28 repeated SessionWindow window = 2;
29 // A non-unique but human-readable name to describe this client. 29 // A non-unique but human-readable name to describe this client.
30 optional string client_name = 3; 30 optional string client_name = 3;
31 // The type of device. 31 // The type of device.
32 enum DeviceType { 32 enum DeviceType {
33 TYPE_PC = 1; 33 TYPE_WIN = 1;
34 TYPE_CROS = 2; 34 TYPE_MAC = 2;
35 TYPE_LINUX = 3;
36 TYPE_CROS = 4;
37 TYPE_OTHER = 5;
ncarter (slow) 2011/08/30 21:52:30 Why do the dangerous renumbering?
Yaron 2011/08/30 21:58:46 This field was just added and has never been used
ncarter (slow) 2011/08/30 21:59:49 OK.
35 } 38 }
36 optional DeviceType device_type = 4; 39 optional DeviceType device_type = 4;
37 } 40 }
38 message SessionWindow { 41 message SessionWindow {
39 // Unique (to the owner) id for this window. 42 // Unique (to the owner) id for this window.
40 optional int32 window_id = 1; 43 optional int32 window_id = 1;
41 // Index of the selected tab in tabs; -1 if no tab is selected. 44 // Index of the selected tab in tabs; -1 if no tab is selected.
42 optional int32 selected_tab_index = 2 [default = -1]; 45 optional int32 selected_tab_index = 2 [default = -1];
43 // Type of the browser. Currently we only store browsers of type 46 // Type of the browser. Currently we only store browsers of type
44 // TYPE_TABBED and TYPE_POPUP. 47 // TYPE_TABBED and TYPE_POPUP.
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 CLIENT_REDIRECT = 1; 107 CLIENT_REDIRECT = 1;
105 SERVER_REDIRECT = 2; 108 SERVER_REDIRECT = 2;
106 } 109 }
107 optional PageTransition page_transition = 6 [default = TYPED]; 110 optional PageTransition page_transition = 6 [default = TYPED];
108 optional PageTransitionQualifier navigation_qualifier = 7; 111 optional PageTransitionQualifier navigation_qualifier = 7;
109 } 112 }
110 113
111 extend EntitySpecifics { 114 extend EntitySpecifics {
112 optional SessionSpecifics session = 50119; 115 optional SessionSpecifics session = 50119;
113 } 116 }
OLDNEW
« no previous file with comments | « chrome/browser/sync/protocol/proto_enum_conversions.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698