Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 7810009: PrintPreview:[MAC] Make Cmd+Opt+P as advance print shortcut to display the native print dialog. (Closed)

Created:
9 years, 3 months ago by kmadhusu
Modified:
9 years, 3 months ago
Reviewers:
csilv, Nico
CC:
chromium-reviews
Visibility:
Public.

Description

PrintPreview:[MAC] Make Cmd+Opt+P as advance print shortcut to display native print dialog. Add "Print Using System Dialog..." option to file menu and set it as a alternate checkbox. nib changes: Duplicated the "print" menu item and put it below the existing item. Renamed the lower item to "Print Using System Dialog..." and set Cmt+Opt+P as its shortcut. Marked the lower item as "alternate". BUG=none TEST=Open a file menu and press the Opt key. Notice "Print Using System Dialog..." option in file menu. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99008

Patch Set 1 #

Total comments: 7
Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -61 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +4 lines, -1 line 3 comments Download
M chrome/app/nibs/MainMenu.xib View 19 chunks +47 lines, -58 lines 4 comments Download
M chrome/browser/global_keyboard_shortcuts_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview_data_source.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
kmadhusu
I have made the changes as per your suggestion. Please review and let me know ...
9 years, 3 months ago (2011-08-31 01:03:51 UTC) #1
csilv
http://codereview.chromium.org/7810009/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/7810009/diff/1/chrome/app/generated_resources.grd#newcode10160 chrome/app/generated_resources.grd:10160: <message name="IDS_PRINT_USING_SYSTEM_DIALOG_MAC" desc="The Mac menu item to print using ...
9 years, 3 months ago (2011-08-31 01:13:23 UTC) #2
csilv
http://codereview.chromium.org/7810009/diff/1/chrome/app/nibs/MainMenu.xib File chrome/app/nibs/MainMenu.xib (right): http://codereview.chromium.org/7810009/diff/1/chrome/app/nibs/MainMenu.xib#newcode402 chrome/app/nibs/MainMenu.xib:402: <string key="NSTitle">^IDS_PRINT_USING_SYSTEM_DIALOG_MAC</string> thakis: I get roughly the same amount ...
9 years, 3 months ago (2011-08-31 17:27:36 UTC) #3
Nico
LGTM with updated CL description. Thanks for the quick turnaround! http://codereview.chromium.org/7810009/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/7810009/diff/1/chrome/app/generated_resources.grd#newcode10160 ...
9 years, 3 months ago (2011-08-31 17:56:47 UTC) #4
kmadhusu
Thanks for all your comments. Updated the CL description. -Kausalya. http://codereview.chromium.org/7810009/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/7810009/diff/1/chrome/app/generated_resources.grd#newcode10160 ...
9 years, 3 months ago (2011-08-31 18:08:00 UTC) #5
csilv
9 years, 3 months ago (2011-08-31 18:10:29 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698