PrintPreview: Make ctrl-shift-p start the native print flow.

chrome/browser/global_keyboard_shortcuts_mac.mm

-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <AppKit/NSEvent.h>
 #include <Carbon/Carbon.h>
 
 #include "chrome/browser/global_keyboard_shortcuts_mac.h"
 
 #include "base/basictypes.h"
 #include "base/logging.h"
@@ skipping 62 matching lines @@
 const KeyboardShortcutData* GetBrowserKeyboardShortcutTable(
     size_t* num_entries) {
   static const KeyboardShortcutData keyboard_shortcuts[] = {
     //cmd   shift  cntrl  option
     //---   -----  -----  ------
     {true,  false, false, false, kVK_LeftArrow,    0,   IDC_BACK},
     {true,  false, false, false, kVK_RightArrow,   0,   IDC_FORWARD},
     {false, false, false, false, kVK_Delete,       0,   IDC_BACK},
     {false, true,  false, false, kVK_Delete,       0,   IDC_FORWARD},
     {true,  true,  false, false, 0,                'c', IDC_DEV_TOOLS_INSPECT},
+    {true,  true,  false, false, 0,                'p', IDC_ADVANCED_PRINT},

[Nico, 2011/08/29 23:43:48]

The way this would normally be done on mac is to edit MainMenu.xib and add a
second menu item below "Print…" called (say) "System Print" and assign it a
shortcut in IB (cmd-shift-p is usually "Page Setup…" on mac, so maybe
cmd-opt-p). You would then set the "Alternate" checkbox. This way, when the user
clicks the file menu and hits opt, he'll see the "Print…" menu item change to
"System Print…", and also when he hits cmd-opt-p, the file menu will flash. You
might want to talk to the UI people about the string.

(You'd put the decimal value belonging to IDC_ADVANCED_PRINT into the new menu
item's tag, and it should be dispatched correctly automatically, without real
code changes.)

[kmadhusu, 2011/08/30 00:27:03]

Thakis: Thanks a lot for the info. I am not a mac user. I wasn't aware of this.
I will make the code changes accordingly. 

   };
 
   *num_entries = arraysize(keyboard_shortcuts);
 
   return keyboard_shortcuts;
 }
 
 static bool MatchesEventForKeyboardShortcut(
     const KeyboardShortcutData& shortcut,
     bool command_key, bool shift_key, bool cntrl_key, bool opt_key,
@@ skipping 118 matching lines @@
           return rawChar;
     }
 
     // opt/alt modifier is set (e.g. on german layout we want '{' for opt-8).
     if ([event modifierFlags] & NSAlternateKeyMask)
       return [characters characterAtIndex:0];
   }
 
   return [eventString characterAtIndex:0];
 }