Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 7796033: Replace AudioDecoderConfig with simple accessors on AudioDecoder. (Closed)

Created:
9 years, 3 months ago by scherkus (not reviewing)
Modified:
9 years, 3 months ago
CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, dpranke+watch-content_chromium.org, jam, annacc+watch_chromium.org, joi+watch-content_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing)
Visibility:
Public.

Description

Replace AudioDecoderConfig with simple accessors on AudioDecoder. AudioDecoderConfig was being used as a struct for outputting format information to an AudioRenderer. This was confusing and in contrast to VideoDecoderConfig, which is is actually used as input to configure a video decoder! Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101563

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -107 lines) Patch
M content/renderer/media/audio_renderer_impl.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/renderer/media/audio_renderer_impl.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M media/audio/audio_parameters.h View 2 chunks +1 line, -4 lines 0 comments Download
M media/audio/audio_parameters.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M media/audio/audio_parameters_unittest.cc View 2 chunks +0 lines, -22 lines 0 comments Download
D media/base/audio_decoder_config.h View 1 chunk +0 lines, -26 lines 0 comments Download
M media/base/filters.h View 1 3 chunks +6 lines, -3 lines 0 comments Download
M media/base/mock_filters.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M media/filters/audio_renderer_base.h View 1 chunk +3 lines, -1 line 0 comments Download
M media/filters/audio_renderer_base.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M media/filters/audio_renderer_base_unittest.cc View 5 chunks +10 lines, -7 lines 0 comments Download
M media/filters/audio_renderer_impl.h View 1 chunk +3 lines, -1 line 0 comments Download
M media/filters/audio_renderer_impl.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M media/filters/ffmpeg_audio_decoder.h View 1 2 chunks +7 lines, -2 lines 0 comments Download
M media/filters/ffmpeg_audio_decoder.cc View 1 3 chunks +18 lines, -9 lines 0 comments Download
M media/filters/ffmpeg_audio_decoder_unittest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M media/filters/null_audio_renderer.h View 1 chunk +3 lines, -1 line 0 comments Download
M media/filters/null_audio_renderer.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M media/media.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
scherkus (not reviewing)
9 years, 3 months ago (2011-09-11 14:49:12 UTC) #1
Ami GONE FROM CHROMIUM
9 years, 3 months ago (2011-09-11 15:04:11 UTC) #2
explicit ReviewConfig(LGTM);

Powered by Google App Engine
This is Rietveld 408576698