Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1905)

Unified Diff: media/base/filters.h

Issue 7796033: Replace AudioDecoderConfig with simple accessors on AudioDecoder. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: rebase Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/audio_decoder_config.h ('k') | media/base/mock_filters.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/filters.h
diff --git a/media/base/filters.h b/media/base/filters.h
index 180739df46f531f21d74b208bc178ddd61486119..faafa4ee5b1863c7cf95596cbdd39ca3253633e0 100644
--- a/media/base/filters.h
+++ b/media/base/filters.h
@@ -31,7 +31,7 @@
#include "base/memory/ref_counted.h"
#include "base/memory/scoped_ptr.h"
#include "base/time.h"
-#include "media/base/audio_decoder_config.h"
+#include "media/base/channel_layout.h"
#include "media/base/media_export.h"
#include "media/base/pipeline_status.h"
#include "media/base/video_frame.h"
@@ -215,8 +215,6 @@ class MEDIA_EXPORT AudioDecoder : public Filter {
virtual void Initialize(DemuxerStream* stream, FilterCallback* callback,
StatisticsCallback* stats_callback) = 0;
- virtual AudioDecoderConfig config() = 0;
-
// Renderer provides an output buffer for Decoder to write to. These buffers
// will be recycled to renderer via the permanent callback.
//
@@ -230,6 +228,11 @@ class MEDIA_EXPORT AudioDecoder : public Filter {
consume_audio_samples_callback_ = callback;
}
+ // Returns various information about the decoded audio format.
+ virtual int bits_per_channel() = 0;
+ virtual ChannelLayout channel_layout() = 0;
+ virtual int sample_rate() = 0;
+
protected:
AudioDecoder();
virtual ~AudioDecoder();
« no previous file with comments | « media/base/audio_decoder_config.h ('k') | media/base/mock_filters.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698