Enable sync for the settings from the Extension Settings API.

chrome/browser/extensions/extension_settings_storage_unittest.h

Index: chrome/browser/extensions/extension_settings_storage_unittest.h
diff --git a/chrome/browser/extensions/extension_settings_storage_unittest.h b/chrome/browser/extensions/extension_settings_storage_unittest.h
index 1d5d66696ceedac22d761d5debb9809b79b91028..f564e41d565f6e172828a61d8d31aea502c6eb4c 100644
--- a/chrome/browser/extensions/extension_settings_storage_unittest.h
+++ b/chrome/browser/extensions/extension_settings_storage_unittest.h
@@ -29,6 +29,7 @@ class ExtensionSettingsStorageTest
   virtual ~ExtensionSettingsStorageTest();
 
   virtual void SetUp() OVERRIDE;
+  virtual void TearDown() OVERRIDE;
 
  protected:
   ExtensionSettingsStorage* storage_;
@@ -54,7 +55,7 @@ class ExtensionSettingsStorageTest
   scoped_ptr<DictionaryValue> dict123_;
 
  private:
-  scoped_refptr<ExtensionSettings> settings_;
+  ExtensionSettings* settings_;

[akalin, 2011/09/20 14:53:11]

No need for this to be a pointer anymore (just have 'ExtensionSettings
settings_;'

[not at google - send to devlin, 2011/09/21 00:20:14]

It's still easier for it to be a pointer, since the constructor takes a
temporary directory and it's a bit convoluted to have this fully constructed on
the stack.

(You need to (1) have a ScopedTempDir, (2) have a utility function to create it
and call CreateNewTempDir, assign it on the stack (3) call
scoped_temp_dir.Set(temp_dir)... easier to just call new at the right time).

[akalin, 2011/09/21 02:05:56]

Ah, that makes sense.  But surely it can be a scoped_ptr<> now, no?  Since it's
not required to be deleted via DeleteSoon now.

[not at google - send to devlin, 2011/09/21 03:55:18]

Yeah it can be a scoped ptr.  I had it this way but it looked strange to have
.reset(settings) in SetUp and .reset() in TearDown; it needs to be symmetrical,
and new/delete is clearly/idiomatically symmetrical wheras
.reset(settings)/.reset().... isn't so clearly.

Anyway, that's why I consciously didn't use scoped_ptr, but I don't feel
strongly.

 
   // Need these so that the DCHECKs for running on FILE or UI threads pass.
   scoped_ptr<MessageLoopForUI> ui_message_loop_;