Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: chrome/browser/extensions/extension_settings_storage_unittest.cc

Issue 7775008: Enable sync for the settings from the Extension Settings API. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Comments, GCC compile fix Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_settings_storage_unittest.cc
diff --git a/chrome/browser/extensions/extension_settings_storage_unittest.cc b/chrome/browser/extensions/extension_settings_storage_unittest.cc
index fc1a36141baab01f36b266a0becb5112fb2239a5..7662cb9270bcddaffbc567e6549a843925b31f3a 100644
--- a/chrome/browser/extensions/extension_settings_storage_unittest.cc
+++ b/chrome/browser/extensions/extension_settings_storage_unittest.cc
@@ -86,8 +86,13 @@ void ExtensionSettingsStorageTest::SetUp() {
FilePath temp_dir;
file_util::CreateNewTempDirectory(FilePath::StringType(), &temp_dir);
settings_ = new ExtensionSettings(temp_dir);
- storage_ = (GetParam())(settings_.get(), "fakeExtension");
- DCHECK(storage_ != NULL);
+ storage_ = (GetParam())(settings_, "fakeExtension");
+ ASSERT_TRUE(storage_ != NULL);
+}
+
+void ExtensionSettingsStorageTest::TearDown() {
+ BrowserThread::DeleteSoon(BrowserThread::FILE, FROM_HERE, settings_);
+ MessageLoop::current()->RunAllPending();
}
TEST_P(ExtensionSettingsStorageTest, GetWhenEmpty) {

Powered by Google App Engine
This is Rietveld 408576698