Enable sync for the settings from the Extension Settings API.

chrome/browser/extensions/extension_settings_storage_unittest.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_SETTINGS_STORAGE_UNITTEST_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_SETTINGS_STORAGE_UNITTEST_H_
 #pragma once
 
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 11 matching lines @@
 // Test fixture for ExtensionSettingsStorage tests.  Tests are defined in
 // extension_settings_storage_unittest.cc with configurations for both cached
 // and non-cached leveldb storage, and cached no-op storage.
 class ExtensionSettingsStorageTest
   : public testing::TestWithParam<ExtensionSettingsStorageTestParam> {
  public:
   ExtensionSettingsStorageTest();
   virtual ~ExtensionSettingsStorageTest();
 
   virtual void SetUp() OVERRIDE;
+  virtual void TearDown() OVERRIDE;
 
  protected:
   ExtensionSettingsStorage* storage_;
 
   std::string key1_;
   std::string key2_;
   std::string key3_;
 
   scoped_ptr<Value> val1_;
   scoped_ptr<Value> val2_;
   scoped_ptr<Value> val3_;
 
   std::vector<std::string> empty_list_;
   std::vector<std::string> list1_;
   std::vector<std::string> list2_;
   std::vector<std::string> list12_;
   std::vector<std::string> list13_;
   std::vector<std::string> list123_;
 
   scoped_ptr<DictionaryValue> empty_dict_;
   scoped_ptr<DictionaryValue> dict1_;
   scoped_ptr<DictionaryValue> dict12_;
   scoped_ptr<DictionaryValue> dict123_;
 
  private:
-  scoped_refptr<ExtensionSettings> settings_;
+  ExtensionSettings* settings_;

[akalin, 2011/09/20 14:53:11]

No need for this to be a pointer anymore (just have 'ExtensionSettings
settings_;'

[not at google - send to devlin, 2011/09/21 00:20:14]

It's still easier for it to be a pointer, since the constructor takes a
temporary directory and it's a bit convoluted to have this fully constructed on
the stack.

(You need to (1) have a ScopedTempDir, (2) have a utility function to create it
and call CreateNewTempDir, assign it on the stack (3) call
scoped_temp_dir.Set(temp_dir)... easier to just call new at the right time).

[akalin, 2011/09/21 02:05:56]

Ah, that makes sense.  But surely it can be a scoped_ptr<> now, no?  Since it's
not required to be deleted via DeleteSoon now.

[not at google - send to devlin, 2011/09/21 03:55:18]

Yeah it can be a scoped ptr.  I had it this way but it looked strange to have
.reset(settings) in SetUp and .reset() in TearDown; it needs to be symmetrical,
and new/delete is clearly/idiomatically symmetrical wheras
.reset(settings)/.reset().... isn't so clearly.

Anyway, that's why I consciously didn't use scoped_ptr, but I don't feel
strongly.

 
   // Need these so that the DCHECKs for running on FILE or UI threads pass.
   scoped_ptr<MessageLoopForUI> ui_message_loop_;
   scoped_ptr<BrowserThread> ui_thread_;
   scoped_ptr<BrowserThread> file_thread_;
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_SETTINGS_STORAGE_UNITTEST_H_