Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 7759001: Revert 98426 - Revert 98103 - Switch to using .pak files for locale data on Windows. (Closed)

Created:
9 years, 4 months ago by battre
Modified:
9 years, 4 months ago
Reviewers:
battre
CC:
chromium-reviews, amit, dhollowa, pam+watch_chromium.org, jshin+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 98426 - Revert 98103 - Switch to using .pak files for locale data on Windows. We were using .dlls, but the .pak files are smaller and this will allow us to share more code across platforms. - Remove app/locales.gyp (used on win to generate the locale dlls) and references to it in other gyp(i) files. - Update various packaging scripts. - Move functions from resource_bundle_posix.cc to resource_bundle.cc (LoadResourcesDataPak, UnloadLocaleResources, GetLocalizedString, LoadLocaleResources) and delete the corresponding functions from resource_bundle_win.cc. Fixes from previous patch: - Made dependencies of packed_resources explicit (MSVS can't figure it out from the inputs). - Removed a couple cases where we were looking for dlls on Windows (in l10n_util.cc and l10n_util_unittest.cc). BUG=92724 TBR=cpu Review URL: http://codereview.chromium.org/7714028 TBR=tony@chromium.org Review URL: http://codereview.chromium.org/7744053 TBR=battre@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98427

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+232 lines, -291 lines) Patch
M build/all.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/chrome_exe.gypi View 3 chunks +1 line, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 4 chunks +2 lines, -6 lines 0 comments Download
M chrome/installer/mini_installer.gyp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/mini_installer/chrome.release View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/build/win/FILES View 1 chunk +49 lines, -49 lines 0 comments Download
M chrome/tools/build/win/FILES.cfg View 1 chunk +49 lines, -49 lines 0 comments Download
M chrome_frame/chrome_frame.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/l10n/l10n_util.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M ui/base/l10n/l10n_util_unittest.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M ui/base/resource/resource_bundle.h View 2 chunks +7 lines, -1 line 0 comments Download
M ui/base/resource/resource_bundle.cc View 4 chunks +86 lines, -2 lines 0 comments Download
M ui/base/resource/resource_bundle_dummy.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/base/resource/resource_bundle_linux.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M ui/base/resource/resource_bundle_posix.cc View 4 chunks +1 line, -68 lines 0 comments Download
M ui/base/resource/resource_bundle_win.cc View 4 chunks +13 lines, -80 lines 0 comments Download
M views/views.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
battre
9 years, 4 months ago (2011-08-26 16:34:57 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698