chrome/browser/resources/http_auth.html - Issue 7757006: Allow no arguments in ConstrainedHtmlUI::OnDialogClose()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/http_auth.html

Issue 7757006: Allow no arguments in ConstrainedHtmlUI::OnDialogClose() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/http_auth.html

diff --git a/chrome/browser/resources/http_auth.html b/chrome/browser/resources/http_auth.html

index 7c72260f43fa4a951b5857e02304f1fdb1034482..93bcccb39aaf68473049270e53a7effde2fa3eed 100644

--- a/chrome/browser/resources/http_auth.html

+++ b/chrome/browser/resources/http_auth.html

@@ -61,7 +61,7 @@

function cancel() {

disableControls();

- chrome.send('DialogClose');

+ chrome.send('DialogClose', ['']);

arv (Not doing code reviews) 2011/09/07 20:41:21 This seems like the wrong way to fix this. Passing

rhashimoto 2011/09/08 23:30:31 Done.

}

function handleSubmit(e) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »