Chromium Code Reviews Chromium Code Reviews
Issue 7757006:
Allow no arguments in ConstrainedHtmlUI::OnDialogClose() (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src| OLD | NEW |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <html i18n-values="dir:textdirection"> | 2 <html i18n-values="dir:textdirection"> |
| 3 <head> | 3 <head> |
| 4 <style type="text/css"> | 4 <style type="text/css"> |
| 5 body { | 5 body { |
| 6 margin: 10px 10px 0 10px; | 6 margin: 10px 10px 0 10px; |
| 7 -webkit-user-select: none; | 7 -webkit-user-select: none; |
| 8 } | 8 } |
| 9 | 9 |
| 10 form { | 10 form { |
| (...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 54 | 54 |
| 55 var result = JSON.stringify({ | 55 var result = JSON.stringify({ |
| 56 'username': $('username').value, | 56 'username': $('username').value, |
| 57 'password': $('password').value}); | 57 'password': $('password').value}); |
| 58 | 58 |
| 59 chrome.send('DialogClose', [result]); | 59 chrome.send('DialogClose', [result]); |
| 60 } | 60 } |
| 61 | 61 |
| 62 function cancel() { | 62 function cancel() { |
| 63 disableControls(); | 63 disableControls(); |
| 64 chrome.send('DialogClose'); | 64 chrome.send('DialogClose', ['']); |
|
arv (Not doing code reviews)
2011/09/07 20:41:21
This seems like the wrong way to fix this. Passing
rhashimoto
2011/09/08 23:30:31
Done.
| |
| 65 } | 65 } |
| 66 | 66 |
| 67 function handleSubmit(e) { | 67 function handleSubmit(e) { |
| 68 sendCredentialsAndClose(); | 68 sendCredentialsAndClose(); |
| 69 e.preventDefault(); | 69 e.preventDefault(); |
| 70 } | 70 } |
| 71 | 71 |
| 72 function handleKeyDown(e) { | 72 function handleKeyDown(e) { |
| 73 if (e.keyCode == 27) { // Escape | 73 if (e.keyCode == 27) { // Escape |
| 74 cancel(); | 74 cancel(); |
| (...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 115 </td> | 115 </td> |
| 116 </tr> | 116 </tr> |
| 117 </table> | 117 </table> |
| 118 <div id="buttons"> | 118 <div id="buttons"> |
| 119 <input id="cancel" type="button" i18n-values="value:cancel"> | 119 <input id="cancel" type="button" i18n-values="value:cancel"> |
| 120 <input id="login" type="submit" i18n-values="value:signin"> | 120 <input id="login" type="submit" i18n-values="value:signin"> |
| 121 </div> | 121 </div> |
| 122 </form> | 122 </form> |
| 123 </body> | 123 </body> |
| 124 </html> | 124 </html> |
| OLD | NEW |
