Allow no arguments in ConstrainedHtmlUI::OnDialogClose()

Allow no arguments in ConstrainedHtmlUI::OnDialogClose().

This fixes a NOTREACHED in ConstrainedHtmlUI::OnDialogClose() when the auth dialog is cancelled.

BUG=none
TEST=ChromeOS debug build should not trace stack and break on clicking HTTP auth cancel button.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100497

[rhashimoto, 2011-08-26 19:46:13]

Hi Erik -

I noticed that in derat@'s CL http://codereview.chromium.org/7709013 (Make WebUI
auth dialog handle Enter and Escape.), you had him change:

  chrome.send('DialogClose', ['']);

to

  chrome.send('DialogClose');

This causes a NOTREACHED() to be reached in ConstrainedHtmlUI::OnDialogClose()
because no argument is present.  Should the argument be added back (as this CL
does) or should we disable that check?

Thanks,
Roy

[Daniel Erat, 2011-08-26 19:47:42]

LGTM if it fixes things. :-)

[rhashimoto, 2011-08-30 18:02:17]

arv: ping

Thanks,
Roy

[rhashimoto, 2011-09-01 17:39:07]

Hi Erik -

Can you please have a look at this CL?  I want to clarify why you had derat@
remove the JSON argument to DialogClose in his CL.

Thanks,
Roy

[rhashimoto, 2011-09-07 16:31:50]

arv: ping

Thanks,
Roy

[arv (Not doing code reviews), 2011-09-07 20:41:21]

http://codereview.chromium.org/7757006/diff/1/chrome/browser/resources/http_a...
File chrome/browser/resources/http_auth.html (right):

http://codereview.chromium.org/7757006/diff/1/chrome/browser/resources/http_a...
chrome/browser/resources/http_auth.html:64: chrome.send('DialogClose', ['']);
This seems like the wrong way to fix this. Passing a dummy argument is very
magic.

Can you fix the message handler to take care of the case where no arguments are
passed.

[rhashimoto, 2011-09-08 23:30:31]

Hi Erik -

I moved the fix into the handler.  PTAL.

Thanks,
Roy

http://codereview.chromium.org/7757006/diff/1/chrome/browser/resources/http_a...
File chrome/browser/resources/http_auth.html (right):

http://codereview.chromium.org/7757006/diff/1/chrome/browser/resources/http_a...
chrome/browser/resources/http_auth.html:64: chrome.send('DialogClose', ['']);
On 2011/09/07 20:41:21, arv wrote:
> This seems like the wrong way to fix this. Passing a dummy argument is very
> magic.
> 
> Can you fix the message handler to take care of the case where no arguments
are
> passed.

Done.

[arv (Not doing code reviews), 2011-09-09 00:16:04]

LGTM

[commit-bot: I haz the power, 2011-09-09 21:10:56]

Change committed as 100497